starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #959] [MERGED] Releases: use flavor to set the tag suffix #1770

New Issue
Closed
opened 2025-12-29 02:31:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/959
Author: @snh
Created: 11/14/2022
Status: ✅ Merged
Merged: 11/15/2022
Merged by: @juanfont

Base: main ← Head: meta

📝 Commits (1)

  • 2e69c49 Releases: use flavor to set the tag suffix

📊 Changes

1 file changed (+5 additions, -7 deletions)

View changed files

📝 .github/workflows/release.yml (+5 -7)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Moves to using the suffix option in flavor from metadata-action to ensure the suffix is applied to all tags. Without this the Alpine image was ending up with the <version> tag instead of the Debian image.

Also removed the type=raw,value=latest and equivalent options from all three images, as the default behavior of latest=auto in flavor should take care of this. The onlatest=true in the suffix option will ensure the Debug and Alpine images will be latest-debug and latest-alpine respectively.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/959 **Author:** [@snh](https://github.com/snh) **Created:** 11/14/2022 **Status:** ✅ Merged **Merged:** 11/15/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `meta` --- ### 📝 Commits (1) - [`2e69c49`](https://github.com/juanfont/headscale/commit/2e69c49ee46d023ec12391e676857e11935369dd) Releases: use flavor to set the tag suffix ### 📊 Changes **1 file changed** (+5 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+5 -7) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> Moves to using the `suffix` option in `flavor` from [metadata-action](https://github.com/docker/metadata-action) to ensure the suffix is applied to all tags. Without this the Alpine image was ending up with the `<version>` tag instead of the Debian image. Also removed the `type=raw,value=latest` and equivalent options from all three images, as the default behavior of `latest=auto` in `flavor` should take care of this. The `onlatest=true` in the `suffix` option will ensure the Debug and Alpine images will be `latest-debug` and `latest-alpine` respectively. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:38 +01:00
adam closed this issue 2025-12-29 02:31:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?