starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #955] [MERGED] Extend TSIC integration interface for non-authkey logins #1766

New Issue
Closed
opened 2025-12-29 02:31:37 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/955
Author: @juanfont
Created: 11/13/2022
Status: ✅ Merged
Merged: 11/13/2022
Merged by: @juanfont

Base: main ← Head: extend-tsic-iface

📝 Commits (4)

  • f7e238a Update Tailscale interface with new Execute signature
  • c197133 Return stderr in tsic.Execute
  • 5e0b829 Added method to run tailscale up without authkey
  • 6d72504 Fixed linter issues

📊 Changes

3 files changed (+54 additions, -18 deletions)

View changed files

📝 integration/general_test.go (+5 -5)
📝 integration/tailscale.go (+3 -1)
📝 integration/tsic/tsic.go (+46 -12)

📄 Description

This PR extends the Tailscale interface to support running tailscale up and returning the result (ie. the login URL)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/955 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 11/13/2022 **Status:** ✅ Merged **Merged:** 11/13/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `extend-tsic-iface` --- ### 📝 Commits (4) - [`f7e238a`](https://github.com/juanfont/headscale/commit/f7e238aae6b3e75569cbad0e8b73d0e836c90b49) Update Tailscale interface with new Execute signature - [`c197133`](https://github.com/juanfont/headscale/commit/c197133dac535b1ed6ae208ecd92e5f66f8438ac) Return stderr in tsic.Execute - [`5e0b829`](https://github.com/juanfont/headscale/commit/5e0b829f440c4800e0b5d285cab620065d3fad52) Added method to run tailscale up without authkey - [`6d72504`](https://github.com/juanfont/headscale/commit/6d725048133aa2258b4a1396faeb3dd31195358b) Fixed linter issues ### 📊 Changes **3 files changed** (+54 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `integration/general_test.go` (+5 -5) 📝 `integration/tailscale.go` (+3 -1) 📝 `integration/tsic/tsic.go` (+46 -12) </details> ### 📄 Description This PR extends the Tailscale interface to support running `tailscale up` and returning the result (ie. the login URL) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:37 +01:00
adam closed this issue 2025-12-29 02:31:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1766
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?