starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #944] [MERGED] Make TLS setup work automatically #1756

New Issue
Closed
opened 2025-12-29 02:31:34 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/944
Author: @kradalby
Created: 11/10/2022
Status: ✅ Merged
Merged: 11/14/2022
Merged by: @juanfont

Base: main ← Head: integration-v2-utils

📝 Commits (10+)

  • 9280828 Make TLS setup work automatically
  • 18873ea Clean up cert function
  • ca98317 Add nolint to gosec stuff that doesnt matter because test
  • 734d0c2 Rename and move wait for headscale
  • 1581892 Remove duplicate function
  • 6aeceba Make TLS setup work automatically
  • 29b7387 Remove duplicate function
  • baf2677 Split ts versions into 2019/2021 for dedicated tests later
  • 8622c7b less verbose command output
  • 7fa66db Fix renamed method

📊 Changes

9 files changed (+472 additions, -156 deletions)

View changed files

📝 integration/auth_web_flow_test.go (+20 -8)
📝 integration/cli_test.go (+29 -16)
📝 integration/control.go (+3 -0)
📝 integration/general_test.go (+5 -4)
📝 integration/hsic/hsic.go (+169 -61)
➕ integration/integrationutil/util.go (+77 -0)
📝 integration/scenario.go (+73 -46)
📝 integration/scenario_test.go (+13 -5)
📝 integration/tsic/tsic.go (+83 -16)

📄 Description

This commit injects the per-test-generated tls certs into the tailscale container and makes sure all can ping all.

It adds several other helper functions

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/944 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/10/2022 **Status:** ✅ Merged **Merged:** 11/14/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `integration-v2-utils` --- ### 📝 Commits (10+) - [`9280828`](https://github.com/juanfont/headscale/commit/9280828d6da257c118e20eb66fda28d07d3e89cf) Make TLS setup work automatically - [`18873ea`](https://github.com/juanfont/headscale/commit/18873eabec4db8c0032b5960e041b6b8674d143a) Clean up cert function - [`ca98317`](https://github.com/juanfont/headscale/commit/ca983174709f34fb71cded365f59ad50daf14d5a) Add nolint to gosec stuff that doesnt matter because test - [`734d0c2`](https://github.com/juanfont/headscale/commit/734d0c2210adcbcfa1afd0c41fd0f7d713dfc9db) Rename and move wait for headscale - [`1581892`](https://github.com/juanfont/headscale/commit/158189201e9e5b2146262503c3afa1b48a335b55) Remove duplicate function - [`6aeceba`](https://github.com/juanfont/headscale/commit/6aeceba3d814d8995929123e772e3cc5a56205be) Make TLS setup work automatically - [`29b7387`](https://github.com/juanfont/headscale/commit/29b7387351d2e8b1578bc8dd68f0a81ea2257832) Remove duplicate function - [`baf2677`](https://github.com/juanfont/headscale/commit/baf26777ac62f7a4850de116e96b4c864d46c013) Split ts versions into 2019/2021 for dedicated tests later - [`8622c7b`](https://github.com/juanfont/headscale/commit/8622c7b9d8f178f37894e33261b659714c84a5ad) less verbose command output - [`7fa66db`](https://github.com/juanfont/headscale/commit/7fa66db544ddac7014c56b7ffb036a6b473364a6) Fix renamed method ### 📊 Changes **9 files changed** (+472 additions, -156 deletions) <details> <summary>View changed files</summary> 📝 `integration/auth_web_flow_test.go` (+20 -8) 📝 `integration/cli_test.go` (+29 -16) 📝 `integration/control.go` (+3 -0) 📝 `integration/general_test.go` (+5 -4) 📝 `integration/hsic/hsic.go` (+169 -61) ➕ `integration/integrationutil/util.go` (+77 -0) 📝 `integration/scenario.go` (+73 -46) 📝 `integration/scenario_test.go` (+13 -5) 📝 `integration/tsic/tsic.go` (+83 -16) </details> ### 📄 Description This commit injects the per-test-generated tls certs into the tailscale container and makes sure all can ping all. It adds several other helper functions Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> <!-- Please tick if the following things apply. You… --> - [ ] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:34 +01:00
adam closed this issue 2025-12-29 02:31:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1756
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?