starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #942] [CLOSED] Add host info to machine #1753

New Issue
Closed
opened 2025-12-29 02:31:33 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/942
Author: @joshuataylor
Created: 11/8/2022
Status: ❌ Closed

Base: main ← Head: feature/machine-info

📝 Commits (4)

  • 32bbaac add machine info
  • 137fb66 add comments
  • 816a9dd Merge branch 'main' into feature/machine-info
  • 707beef Merge branch 'main' into feature/machine-info

📊 Changes

11 files changed (+677 additions, -134 deletions)

View changed files

📝 db.go (+47 -0)
📝 gen/go/headscale/v1/apikey.pb.go (+1 -1)
📝 gen/go/headscale/v1/device.pb.go (+1 -1)
📝 gen/go/headscale/v1/headscale.pb.go (+19 -19)
📝 gen/go/headscale/v1/machine.pb.go (+442 -110)
📝 gen/go/headscale/v1/namespace.pb.go (+1 -1)
📝 gen/go/headscale/v1/preauthkey.pb.go (+1 -1)
📝 gen/go/headscale/v1/routes.pb.go (+1 -1)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+98 -0)
📝 machine.go (+2 -0)
📝 proto/headscale/v1/machine.proto (+64 -0)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Hi,

I would like to have the hostInfo exposed, which allows gGRPC to show full host info.

See here: https://pkg.go.dev/tailscale.com/tailcfg@v1.32.2#Hostinfo

I'm unsure how to add tests around this.

I've tested this with my service which calls the gRPC endpoint, and it works 🎉.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/942 **Author:** [@joshuataylor](https://github.com/joshuataylor) **Created:** 11/8/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/machine-info` --- ### 📝 Commits (4) - [`32bbaac`](https://github.com/juanfont/headscale/commit/32bbaac89253776a22606230f81f0bda5b21cdd2) add machine info - [`137fb66`](https://github.com/juanfont/headscale/commit/137fb66ad5d2d82b2860c4ef4dc928f4c9959c4e) add comments - [`816a9dd`](https://github.com/juanfont/headscale/commit/816a9dd98678fb408e34808bfc6dfd3f21675c22) Merge branch 'main' into feature/machine-info - [`707beef`](https://github.com/juanfont/headscale/commit/707beef115200a15eb0718a5cbf203be3cbfd1b3) Merge branch 'main' into feature/machine-info ### 📊 Changes **11 files changed** (+677 additions, -134 deletions) <details> <summary>View changed files</summary> 📝 `db.go` (+47 -0) 📝 `gen/go/headscale/v1/apikey.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/device.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/headscale.pb.go` (+19 -19) 📝 `gen/go/headscale/v1/machine.pb.go` (+442 -110) 📝 `gen/go/headscale/v1/namespace.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/preauthkey.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/routes.pb.go` (+1 -1) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+98 -0) 📝 `machine.go` (+2 -0) 📝 `proto/headscale/v1/machine.proto` (+64 -0) </details> ### 📄 Description - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md Hi, I would like to have the hostInfo exposed, which allows gGRPC to show full host info. See here: https://pkg.go.dev/tailscale.com/tailcfg@v1.32.2#Hostinfo I'm unsure how to add tests around this. I've tested this with my service which calls the gRPC endpoint, and it works :tada:. <img width="609" alt="image" src="https://user-images.githubusercontent.com/225131/200462192-d6e0f768-756f-4c23-bf33-15ad3863fb1c.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:33 +01:00
adam closed this issue 2025-12-29 02:31:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1753
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?