starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #929] [CLOSED] Add auth web flow integration tests #1745

New Issue
Closed
opened 2025-12-29 02:31:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/929
Author: @juanfont
Created: 11/4/2022
Status: ❌ Closed

Base: main ← Head: web-auth-flow-tests

📝 Commits (10+)

  • e270cf6 Return stderr in tsic.Execute
  • 181f1ee Added method to run tailscale up without authkey
  • ec90e9d Update Tailscale interface with new Execute signature
  • 658478c Add web flow auth basic integration test
  • 45cb0f3 Typo
  • 5d7eae4 Always attempt to parse login url
  • b2dc480 Return the real port of the container
  • 3a6ef6b Work in progress for web auth flow
  • bbc8cb1 Added makefile and .github
  • 825e883 Renamed integration tests for auth

📊 Changes

9 files changed (+306 additions, -18 deletions)

View changed files

➕ .github/workflows/test-integration-v2-general-auth.yml (+35 -0)
📝 .golangci.yaml (+3 -0)
📝 Makefile (+11 -0)
📝 cmd/headscale/cli/nodes.go (+1 -1)
➕ integration/auth_web_flow_test.go (+192 -0)
📝 integration/general_test.go (+5 -5)
📝 integration/hsic/hsic.go (+1 -3)
📝 integration/tailscale.go (+4 -1)
📝 integration/tsic/tsic.go (+54 -8)

📄 Description

We had missing the integration tests for the web flow auth. We had already for auth keys and OIDC.

This PR adds those tests, using the v2 of the integration system. As soon as it works...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/929 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 11/4/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `web-auth-flow-tests` --- ### 📝 Commits (10+) - [`e270cf6`](https://github.com/juanfont/headscale/commit/e270cf6d20a77e800634c980a51f59daedcb804b) Return stderr in tsic.Execute - [`181f1ee`](https://github.com/juanfont/headscale/commit/181f1eeb4fd968f45c8ba11bbd3752eacd3e0df3) Added method to run tailscale up without authkey - [`ec90e9d`](https://github.com/juanfont/headscale/commit/ec90e9d7166b656b610acd042f071b5e28a5c463) Update Tailscale interface with new Execute signature - [`658478c`](https://github.com/juanfont/headscale/commit/658478cba3cbcc9a896987810c41e130afc6d61d) Add web flow auth basic integration test - [`45cb0f3`](https://github.com/juanfont/headscale/commit/45cb0f3fa38bc5f9ad5d70d23640aa6c1e1b3ba5) Typo - [`5d7eae4`](https://github.com/juanfont/headscale/commit/5d7eae46f8defeb62ba38f9e57e622961c3b86a2) Always attempt to parse login url - [`b2dc480`](https://github.com/juanfont/headscale/commit/b2dc480f229e581634fe366776abd0c677ad8de7) Return the real port of the container - [`3a6ef6b`](https://github.com/juanfont/headscale/commit/3a6ef6becea16f456b39ed2d0faed55249ee5e43) Work in progress for web auth flow - [`bbc8cb1`](https://github.com/juanfont/headscale/commit/bbc8cb11da01e4e74fa94612cef7c833b10115d2) Added makefile and .github - [`825e883`](https://github.com/juanfont/headscale/commit/825e88311e4ed803c09b37ab958a3664b90b2c00) Renamed integration tests for auth ### 📊 Changes **9 files changed** (+306 additions, -18 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/test-integration-v2-general-auth.yml` (+35 -0) 📝 `.golangci.yaml` (+3 -0) 📝 `Makefile` (+11 -0) 📝 `cmd/headscale/cli/nodes.go` (+1 -1) ➕ `integration/auth_web_flow_test.go` (+192 -0) 📝 `integration/general_test.go` (+5 -5) 📝 `integration/hsic/hsic.go` (+1 -3) 📝 `integration/tailscale.go` (+4 -1) 📝 `integration/tsic/tsic.go` (+54 -8) </details> ### 📄 Description We had missing the integration tests for the web flow auth. We had already for auth keys and OIDC. This PR adds those tests, using the v2 of the integration system. As soon as it works... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:32 +01:00
adam closed this issue 2025-12-29 02:31:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1745
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?