starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #928] [MERGED] Add build flag to enable TS2019 #1744

New Issue
Closed
opened 2025-12-29 02:31:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/928
Author: @kradalby
Created: 11/3/2022
Status: ✅ Merged
Merged: 11/4/2022
Merged by: @kradalby

Base: main ← Head: experiment-disable-ts2019

📝 Commits (3)

📊 Changes

11 files changed (+51 additions, -12 deletions)

View changed files

📝 .goreleaser.yml (+8 -0)
📝 CHANGELOG.md (+1 -0)
📝 Dockerfile (+1 -1)
📝 Dockerfile.debug (+1 -1)
📝 Makefile (+8 -6)
📝 app.go (+2 -3)
📝 flake.nix (+3 -1)
➕ handler_legacy.go (+15 -0)
➕ handler_placeholder.go (+8 -0)
📝 protocol_legacy.go (+2 -0)
📝 protocol_legacy_poll.go (+2 -0)

📄 Description

This commit starts an experiment to disable TS2019 (we also call it
legacy).

The two main goals for this right now is:

  • Diasble TS2019, and verify that the integration test clients with the
    appropriate TS2021 support works as expected
  • Get an overview of how coupled the protocol code is, if this is easy,
    it will be easy to remove when the time comes.

Also, users with "crazy" desires like only supporting the most modern
protocol can build this version.

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/928 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/3/2022 **Status:** ✅ Merged **Merged:** 11/4/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `experiment-disable-ts2019` --- ### 📝 Commits (3) - [`ec81db5`](https://github.com/juanfont/headscale/commit/ec81db5c11f3d78acbe5ad48bee621dc6445bb8b) Add build flag to disable TS2019 - [`c6e8067`](https://github.com/juanfont/headscale/commit/c6e8067f7c100a6b2383569784bb169fb9d105d2) Update changelog - [`2582ffa`](https://github.com/juanfont/headscale/commit/2582ffa8e6b4bd52bf48d14097e18760b6dcb58d) Update tags everywhere ### 📊 Changes **11 files changed** (+51 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `.goreleaser.yml` (+8 -0) 📝 `CHANGELOG.md` (+1 -0) 📝 `Dockerfile` (+1 -1) 📝 `Dockerfile.debug` (+1 -1) 📝 `Makefile` (+8 -6) 📝 `app.go` (+2 -3) 📝 `flake.nix` (+3 -1) ➕ `handler_legacy.go` (+15 -0) ➕ `handler_placeholder.go` (+8 -0) 📝 `protocol_legacy.go` (+2 -0) 📝 `protocol_legacy_poll.go` (+2 -0) </details> ### 📄 Description This commit starts an experiment to disable TS2019 (we also call it legacy). The two main goals for this right now is: - Diasble TS2019, and verify that the integration test clients with the appropriate TS2021 support works as expected - Get an overview of how coupled the protocol code is, if this is easy, it will be easy to remove when the time comes. Also, users with "crazy" desires like only supporting the most modern protocol _can_ build this version. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:31 +01:00
adam closed this issue 2025-12-29 02:31:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?