starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #915] [MERGED] feat: add information to the /apple page for the macOS standalone client user #1735

New Issue
Closed
opened 2025-12-29 02:31:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/915
Author: @CNLHC
Created: 11/2/2022
Status: ✅ Merged
Merged: 11/4/2022
Merged by: @kradalby

Base: main ← Head: update_apple_page

📝 Commits (6)

  • 04a15aa info of connect from macos standalone cli
  • e81449b fix all golanglint-ci problem
  • b2c4e15 template -> templates
  • a49e6cc Merge branch 'main' into update_apple_page
  • 8242718 make fmt
  • 73e98d4 Merge branch 'main' into update_apple_page

📊 Changes

4 files changed (+216 additions, -105 deletions)

View changed files

📝 platform_config.go (+49 -104)
➕ templates/apple.html (+102 -0)
➕ templates/windows.html (+64 -0)
📝 utils.go (+1 -1)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

#912

Besides the new configuration, This PR introduces the embed package to this project.

The verbose HTML files are hard to edit in the go source code. Moving them to separate files has many benefits including a better editing experience and the potential to add more advanced features to the front (e.g. prettier UI or interactive login)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/915 **Author:** [@CNLHC](https://github.com/CNLHC) **Created:** 11/2/2022 **Status:** ✅ Merged **Merged:** 11/4/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `update_apple_page` --- ### 📝 Commits (6) - [`04a15aa`](https://github.com/juanfont/headscale/commit/04a15aa307c3593d5098ff2ffb922f1c06e04b17) info of connect from macos standalone cli - [`e81449b`](https://github.com/juanfont/headscale/commit/e81449b25f001c96d0787340eadecb7d3f5b1411) fix all golanglint-ci problem - [`b2c4e15`](https://github.com/juanfont/headscale/commit/b2c4e1507f0ca052bd35cc98922437e732e26e8e) template -> templates - [`a49e6cc`](https://github.com/juanfont/headscale/commit/a49e6ccfdf0682eba77c8eb16a1befb96aa4c2af) Merge branch 'main' into update_apple_page - [`8242718`](https://github.com/juanfont/headscale/commit/8242718316352d2e4795727ca34431c4187cf387) make fmt - [`73e98d4`](https://github.com/juanfont/headscale/commit/73e98d4adf31a9008f1bf90ea62a186a205a7ecb) Merge branch 'main' into update_apple_page ### 📊 Changes **4 files changed** (+216 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `platform_config.go` (+49 -104) ➕ `templates/apple.html` (+102 -0) ➕ `templates/windows.html` (+64 -0) 📝 `utils.go` (+1 -1) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> #912 Besides the new configuration, This PR introduces the `embed` package to this project. The verbose HTML files are hard to edit in the go source code. Moving them to separate files has many benefits including a better editing experience and the potential to add more advanced features to the front (e.g. prettier UI or interactive login) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:29 +01:00
adam closed this issue 2025-12-29 02:31:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?