starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #914] [MERGED] fix bug in #912 #1734

New Issue
Closed
opened 2025-12-29 02:31:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/914
Author: @CNLHC
Created: 11/2/2022
Status: ✅ Merged
Merged: 11/5/2022
Merged by: @kradalby

Base: main ← Head: fix_registration_bug

📝 Commits (5)

📊 Changes

8 files changed (+47 additions, -35 deletions)

View changed files

📝 .golangci.yaml (+1 -0)
📝 cmd/headscale/cli/debug.go (+4 -4)
📝 grpcv1.go (+8 -2)
📝 integration_cli_test.go (+22 -22)
📝 integration_oidc_test.go (+1 -1)
📝 machine.go (+7 -1)
📝 oidc.go (+1 -2)
📝 protocol_common.go (+3 -3)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/914 **Author:** [@CNLHC](https://github.com/CNLHC) **Created:** 11/2/2022 **Status:** ✅ Merged **Merged:** 11/5/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix_registration_bug` --- ### 📝 Commits (5) - [`472e58c`](https://github.com/juanfont/headscale/commit/472e58cc653aec5e0e4dd65476013a8769e4f585) fix bug in #912 - [`0b40cdd`](https://github.com/juanfont/headscale/commit/0b40cdddbf2702888af7c64d16b0641fe4bf8df5) fix typo - [`c691d8b`](https://github.com/juanfont/headscale/commit/c691d8b8a700168f45442349362573758d9dd727) fix integration test - [`1d8400d`](https://github.com/juanfont/headscale/commit/1d8400dd5ec4129c9de01bfc4564e128110105b8) remove unused var - [`a9f1394`](https://github.com/juanfont/headscale/commit/a9f139416682420a05346bfc6afa34ec2fccacf7) fix oidc test and lint error ### 📊 Changes **8 files changed** (+47 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `.golangci.yaml` (+1 -0) 📝 `cmd/headscale/cli/debug.go` (+4 -4) 📝 `grpcv1.go` (+8 -2) 📝 `integration_cli_test.go` (+22 -22) 📝 `integration_oidc_test.go` (+1 -1) 📝 `machine.go` (+7 -1) 📝 `oidc.go` (+1 -2) 📝 `protocol_common.go` (+3 -3) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:29 +01:00
adam closed this issue 2025-12-29 02:31:29 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1734
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?