starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #911] [CLOSED] Registration bug #1732

New Issue
Closed
opened 2025-12-29 02:31:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/911
Author: @CNLHC
Created: 11/2/2022
Status: ❌ Closed

Base: main ← Head: registration_bug

📝 Commits (3)

  • 5420880 add configuration for mac standalone client
  • fffcf2a update the apple hint page
  • a13fa03 fix machine registration bug via an extra cache abstraction

📊 Changes

7 files changed (+165 additions, -76 deletions)

View changed files

📝 app.go (+6 -9)
📝 grpcv1.go (+8 -6)
📝 machine.go (+26 -25)
📝 oidc.go (+2 -2)
📝 platform_config.go (+65 -22)
📝 protocol_common.go (+4 -12)
➕ registration_cache.go (+54 -0)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/911 **Author:** [@CNLHC](https://github.com/CNLHC) **Created:** 11/2/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `registration_bug` --- ### 📝 Commits (3) - [`5420880`](https://github.com/juanfont/headscale/commit/54208804672460206afc93730c3d7a183f14c264) add configuration for mac standalone client - [`fffcf2a`](https://github.com/juanfont/headscale/commit/fffcf2a89c3d24cd8cb1b36872f1520cfe9ca32b) update the apple hint page - [`a13fa03`](https://github.com/juanfont/headscale/commit/a13fa037d4540338013ae93a38d05236e9c3fda7) fix machine registration bug via an extra cache abstraction ### 📊 Changes **7 files changed** (+165 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `app.go` (+6 -9) 📝 `grpcv1.go` (+8 -6) 📝 `machine.go` (+26 -25) 📝 `oidc.go` (+2 -2) 📝 `platform_config.go` (+65 -22) 📝 `protocol_common.go` (+4 -12) ➕ `registration_cache.go` (+54 -0) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:29 +01:00
adam closed this issue 2025-12-29 02:31:29 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?