starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #865] [MERGED] Do not use build tags for running integration tests #1695

New Issue
Closed
opened 2025-12-29 02:31:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:15 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/865
Author: @kradalby
Created: 10/18/2022
Status: ✅ Merged
Merged: 10/18/2022
Merged by: @juanfont

Base: main ← Head: integration-no-build-tags

📝 Commits (5)

  • 32c21a0 cache go mod in docker, speed up local
  • c6f82c3 Switch from hacking buildtags to selecting tests
  • dfadb96 Use short test to signal that we dont run integration
  • 4df47de add nolint to integrationtests, they are going away ™️
  • 2f36a11 use short flag for nix build test

📊 Changes

7 files changed (+40 additions, -25 deletions)

View changed files

📝 Makefile (+9 -5)
📝 flake.nix (+3 -0)
📝 integration_cli_test.go (+6 -3)
📝 integration_common_test.go (+1 -3)
📝 integration_embedded_derp_test.go (+7 -6)
📝 integration_general_test.go (+7 -4)
📝 integration_oidc_test.go (+7 -4)

📄 Description

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/865 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 10/18/2022 **Status:** ✅ Merged **Merged:** 10/18/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `integration-no-build-tags` --- ### 📝 Commits (5) - [`32c21a0`](https://github.com/juanfont/headscale/commit/32c21a05f881698ac625f531785ba076745b4002) cache go mod in docker, speed up local - [`c6f82c3`](https://github.com/juanfont/headscale/commit/c6f82c36463e5e66e9ced6190ad7875bc924b6de) Switch from hacking buildtags to selecting tests - [`dfadb96`](https://github.com/juanfont/headscale/commit/dfadb965b7014618848afe706d7916c3b3519495) Use short test to signal that we dont run integration - [`4df47de`](https://github.com/juanfont/headscale/commit/4df47de3f29cc11a397bf3f1e4da8176c0b57439) add nolint to integrationtests, they are going away :tm: - [`2f36a11`](https://github.com/juanfont/headscale/commit/2f36a11a8eee8bfe723d323aee6b887435bfd138) use short flag for nix build test ### 📊 Changes **7 files changed** (+40 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+9 -5) 📝 `flake.nix` (+3 -0) 📝 `integration_cli_test.go` (+6 -3) 📝 `integration_common_test.go` (+1 -3) 📝 `integration_embedded_derp_test.go` (+7 -6) 📝 `integration_general_test.go` (+7 -4) 📝 `integration_oidc_test.go` (+7 -4) </details> ### 📄 Description Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:15 +01:00
adam closed this issue 2025-12-29 02:31:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1695
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?