starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #863] [MERGED] Provide LoginName when registering with pre-auth key #1693

New Issue
Closed
opened 2025-12-29 02:31:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:15 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/863
Author: @magichuihui
Created: 10/18/2022
Status: ✅ Merged
Merged: 11/6/2022
Merged by: @kradalby

Base: main ← Head: main

📝 Commits (1)

  • 6b0e6c0 Provide LoginName when registering with pre-auth key

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 protocol_common.go (+4 -0)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

When register with pre-auth key, headscale doesn't provide LoginName which is needed by tailscaled.state.
So it has to execute tailscale up twice to fetch the property.

{
	"ControlURL": "",
	"RouteAll": false,
	"AllowSingleHosts": true,
	"ExitNodeID": "",
	"ExitNodeIP": "",
	"ExitNodeAllowLANAccess": false,
	"CorpDNS": false,
	"RunSSH": false,
	"WantRunning": true,
	"LoggedOut": false,
	"ShieldsUp": false,
	"AdvertiseTags": null,
	"Hostname": "",
	"NotepadURLs": false,
	"AdvertiseRoutes": [],
	"NoSNAT": false,
	"NetfilterMode": 2,
	"Config": {
		"PrivateMachineKey": "privkey:0",
		"PrivateNodeKey": "privkey:0",
		"OldPrivateNodeKey": "privkey:0",
		"Provider": "",
		"LoginName": ""
	}

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/863 **Author:** [@magichuihui](https://github.com/magichuihui) **Created:** 10/18/2022 **Status:** ✅ Merged **Merged:** 11/6/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`6b0e6c0`](https://github.com/juanfont/headscale/commit/6b0e6c0ceeb80621efc1182b2596a904d0c03e62) Provide LoginName when registering with pre-auth key ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `protocol_common.go` (+4 -0) </details> ### 📄 Description - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [x] updated documentation if needed - [ ] updated CHANGELOG.md When register with pre-auth key, headscale doesn't provide `LoginName` which is needed by `tailscaled.state`. So it has to execute `tailscale up` twice to fetch the property. ```json { "ControlURL": "", "RouteAll": false, "AllowSingleHosts": true, "ExitNodeID": "", "ExitNodeIP": "", "ExitNodeAllowLANAccess": false, "CorpDNS": false, "RunSSH": false, "WantRunning": true, "LoggedOut": false, "ShieldsUp": false, "AdvertiseTags": null, "Hostname": "", "NotepadURLs": false, "AdvertiseRoutes": [], "NoSNAT": false, "NetfilterMode": 2, "Config": { "PrivateMachineKey": "privkey:0", "PrivateNodeKey": "privkey:0", "OldPrivateNodeKey": "privkey:0", "Provider": "", "LoginName": "" } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:15 +01:00
adam closed this issue 2025-12-29 02:31:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1693
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?