starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #853] [MERGED] Fix the proposed noise private_key_path #1685

New Issue
Closed
opened 2025-12-29 02:31:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/853
Author: @zhzy0077
Created: 10/11/2022
Status: ✅ Merged
Merged: 10/13/2022
Merged by: @juanfont

Base: main ← Head: patch-1

📝 Commits (2)

  • 073308f Fix the proposed noise private_key_path
  • 88d1287 Merge branch 'main' into patch-1

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 docs/running-headscale-container.md (+1 -1)

📄 Description

As indicated by the comment, the default /var/lib/headscale path is not writable in the container. However the sample setting is not following that like private_key_path

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

None of above applies as it's just a simple typo fix.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/853 **Author:** [@zhzy0077](https://github.com/zhzy0077) **Created:** 10/11/2022 **Status:** ✅ Merged **Merged:** 10/13/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`073308f`](https://github.com/juanfont/headscale/commit/073308f1a330af550801f85292614a08da252c15) Fix the proposed noise private_key_path - [`88d1287`](https://github.com/juanfont/headscale/commit/88d12873c53b6f6cc0e614f8c12e3324db54ad21) Merge branch 'main' into patch-1 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/running-headscale-container.md` (+1 -1) </details> ### 📄 Description As indicated by the comment, the default /var/lib/headscale path is not writable in the container. However the sample setting is not following that like `private_key_path` <!-- Please tick if the following things apply. You… --> - [X] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> None of above applies as it's just a simple typo fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:13 +01:00
adam closed this issue 2025-12-29 02:31:13 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1685
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?