starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #844] [MERGED] Run integration tests inside docker, dont depend on local platform #1681

New Issue
Closed
opened 2025-12-29 02:31:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/844
Author: @kradalby
Created: 10/3/2022
Status: ✅ Merged
Merged: 10/8/2022
Merged by: @kradalby

Base: main ← Head: container-exist-fix

📝 Commits (10+)

  • 6b67584 Fix DERP name in integration tests
  • 4904ccc Make sure mock container is removed before started
  • 201f81c Make sure mockoidc is up, has unique name and removed if exist
  • 382a37f Test against last patch version
  • 37a4d41 Make addr configurable
  • a0ec369 Fix error declaration
  • aca3a66 Fix declaration of pointer
  • 85df2c8 Run oidc tests fully in docker
  • f3dbfc9 Style change
  • 8893100 Fail correctly if container exist

📊 Changes

9 files changed (+206 additions, -59 deletions)

View changed files

📝 Makefile (+28 -4)
📝 cmd/headscale/cli/mockoidc.go (+5 -1)
📝 flake.nix (+7 -1)
📝 integration_cli_test.go (+14 -7)
📝 integration_common_test.go (+30 -4)
📝 integration_embedded_derp_test.go (+29 -15)
📝 integration_general_test.go (+23 -6)
📝 integration_oidc_test.go (+69 -20)
📝 integration_test/etc_oidc/base_config.yaml (+1 -1)

📄 Description

Signed-off-by: Kristoffer Dalby kristoffer@dalby.cc

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/844 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 10/3/2022 **Status:** ✅ Merged **Merged:** 10/8/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `container-exist-fix` --- ### 📝 Commits (10+) - [`6b67584`](https://github.com/juanfont/headscale/commit/6b67584d477946cd83b8fa70d9cb3e4ce53703d7) Fix DERP name in integration tests - [`4904ccc`](https://github.com/juanfont/headscale/commit/4904ccc3c3598a391d46e9150f6f84d6e92156a4) Make sure mock container is removed before started - [`201f81c`](https://github.com/juanfont/headscale/commit/201f81ce00a34c867ecc229fbbae4f32aa626cb8) Make sure mockoidc is up, has unique name and removed if exist - [`382a37f`](https://github.com/juanfont/headscale/commit/382a37f1e16a51b35d7975415b96a3e50274068c) Test against last patch version - [`37a4d41`](https://github.com/juanfont/headscale/commit/37a4d41d0ef729daf195f6bda4f6d95781940727) Make addr configurable - [`a0ec369`](https://github.com/juanfont/headscale/commit/a0ec3690b6ea49c2343f8dcd975868811e921ec0) Fix error declaration - [`aca3a66`](https://github.com/juanfont/headscale/commit/aca3a667c49803fcb92052aa3a8a6648cdc99117) Fix declaration of pointer - [`85df2c8`](https://github.com/juanfont/headscale/commit/85df2c80a84860290901a249f2cf081e876e66e1) Run oidc tests fully in docker - [`f3dbfc9`](https://github.com/juanfont/headscale/commit/f3dbfc9045ca5f49c80e90cbe15770d3c2d00b94) Style change - [`8893100`](https://github.com/juanfont/headscale/commit/88931001fd996ae50b198407fceb8f9ff36279e2) Fail correctly if container exist ### 📊 Changes **9 files changed** (+206 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+28 -4) 📝 `cmd/headscale/cli/mockoidc.go` (+5 -1) 📝 `flake.nix` (+7 -1) 📝 `integration_cli_test.go` (+14 -7) 📝 `integration_common_test.go` (+30 -4) 📝 `integration_embedded_derp_test.go` (+29 -15) 📝 `integration_general_test.go` (+23 -6) 📝 `integration_oidc_test.go` (+69 -20) 📝 `integration_test/etc_oidc/base_config.yaml` (+1 -1) </details> ### 📄 Description Signed-off-by: Kristoffer Dalby <kristoffer@dalby.cc> <!-- Please tick if the following things apply. You… --> - [ ] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:12 +01:00
adam closed this issue 2025-12-29 02:31:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?