starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #829] [MERGED] Add option to allow headscale to start if OIDC fails to initialise #1672

New Issue
Closed
opened 2025-12-29 02:31:10 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/829
Author: @kradalby
Created: 9/26/2022
Status: ✅ Merged
Merged: 9/26/2022
Merged by: @kradalby

Base: main ← Head: oidc-dependency

📝 Commits (6)

  • 8dcc82c Use oidc if it initialised, not if it is configured
  • dbe58e5 Allow headscale to start if oidc setup fails.
  • fb25a06 Preserve current behaviour with a config flag
  • 6b4d533 Update changelog
  • 256b6cb Add new option to config-example
  • 2462989 Add new config option to cli integration tests

📊 Changes

8 files changed (+23 additions, -11 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 app.go (+3 -1)
📝 config-example.yaml (+1 -0)
📝 config.go (+13 -8)
📝 integration_test/etc/alt-config.dump.gold.yaml (+1 -0)
📝 integration_test/etc/alt-env-config.dump.gold.yaml (+1 -0)
📝 integration_test/etc/config.dump.gold.yaml (+1 -0)
📝 protocol_common.go (+2 -2)

📄 Description

OIDC might be configured, but unable to be initialised, this only runs
the oidc cycle if it is actually successfully set up/initialised.

Fixes #827

Signed-off-by: Kristoffer Dalby kristoffer@dalby.cc

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/829 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 9/26/2022 **Status:** ✅ Merged **Merged:** 9/26/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `oidc-dependency` --- ### 📝 Commits (6) - [`8dcc82c`](https://github.com/juanfont/headscale/commit/8dcc82ceb38123ac417c79da734e9fd7654d4695) Use oidc if it initialised, not if it is configured - [`dbe58e5`](https://github.com/juanfont/headscale/commit/dbe58e53e4af65a23c5f54b3f9de37957f4ba5ee) Allow headscale to start if oidc setup fails. - [`fb25a06`](https://github.com/juanfont/headscale/commit/fb25a06a662c1f11235f9a7f669a4a237b1873be) Preserve current behaviour with a config flag - [`6b4d533`](https://github.com/juanfont/headscale/commit/6b4d53315bc54b1225feb4d8c15e9df6ae6a1dae) Update changelog - [`256b6cb`](https://github.com/juanfont/headscale/commit/256b6cb54dab6509b44eb7ebd237fe89d6276689) Add new option to config-example - [`2462989`](https://github.com/juanfont/headscale/commit/24629895c787d98bc0601130eb21b736d0d2be3e) Add new config option to cli integration tests ### 📊 Changes **8 files changed** (+23 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `app.go` (+3 -1) 📝 `config-example.yaml` (+1 -0) 📝 `config.go` (+13 -8) 📝 `integration_test/etc/alt-config.dump.gold.yaml` (+1 -0) 📝 `integration_test/etc/alt-env-config.dump.gold.yaml` (+1 -0) 📝 `integration_test/etc/config.dump.gold.yaml` (+1 -0) 📝 `protocol_common.go` (+2 -2) </details> ### 📄 Description OIDC might be configured, but unable to be initialised, this only runs the oidc cycle if it is actually successfully set up/initialised. Fixes #827 Signed-off-by: Kristoffer Dalby <kristoffer@dalby.cc><!-- Please tick if the following things apply. You… --> - [ ] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:10 +01:00
adam closed this issue 2025-12-29 02:31:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1672
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?