starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #707] [MERGED] Fix bug in excludeCorrectlyTaggedNodes #1586

New Issue
Closed
opened 2025-12-29 02:30:50 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:50 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/707
Author: @restanrm
Created: 8/4/2022
Status: ✅ Merged
Merged: 8/11/2022
Merged by: @juanfont

Base: main ← Head: fix-bug-in-excludecorrectlytaggednodes

📝 Commits (5)

  • babf947 fix(acl): fix issue with groups in excludeCorretlyTaggedNodes
  • 79688e6 chore(all): apply formater
  • bce5934 docs: add entry in changelog
  • 0bb205d Merge remote-tracking branch 'origin/main' into fix-bug-in-excludecorrectlytaggednodes
  • 110b01b Merge remote-tracking branch 'origin/main' into fix-bug-in-excludecorrectlytaggednodes

📊 Changes

17 files changed (+199 additions, -44 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 acls.go (+19 -4)
📝 acls_test.go (+92 -12)
📝 acls_types.go (+5 -5)
📝 api.go (+9 -2)
📝 app.go (+16 -6)
📝 cmd/headscale/cli/api_key.go (+3 -1)
📝 cmd/headscale/cli/preauthkeys.go (+3 -1)
📝 cmd/headscale/cli/utils.go (+4 -1)
📝 grpcv1.go (+1 -1)
📝 integration_cli_test.go (+7 -1)
📝 integration_common_test.go (+5 -3)
📝 integration_embedded_derp_test.go (+7 -1)
📝 integration_general_test.go (+7 -1)
📝 machine_test.go (+10 -2)
📝 oidc.go (+5 -1)
📝 platform_config.go (+5 -2)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #563

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/707 **Author:** [@restanrm](https://github.com/restanrm) **Created:** 8/4/2022 **Status:** ✅ Merged **Merged:** 8/11/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `fix-bug-in-excludecorrectlytaggednodes` --- ### 📝 Commits (5) - [`babf947`](https://github.com/juanfont/headscale/commit/babf9470c25eb9b8703ccf28c2caa70c0ed2feba) fix(acl): fix issue with groups in excludeCorretlyTaggedNodes - [`79688e6`](https://github.com/juanfont/headscale/commit/79688e618732525777a37f47fcfdf2df0800f5f8) chore(all): apply formater - [`bce5934`](https://github.com/juanfont/headscale/commit/bce59345e42ba7d9e11bba894ff5ce6cc00469a1) docs: add entry in changelog - [`0bb205d`](https://github.com/juanfont/headscale/commit/0bb205d31f6aeb2c02473e71aabc9479b67300ba) Merge remote-tracking branch 'origin/main' into fix-bug-in-excludecorrectlytaggednodes - [`110b01b`](https://github.com/juanfont/headscale/commit/110b01befa84429c2227ab8aa7bce035b0f7d0e7) Merge remote-tracking branch 'origin/main' into fix-bug-in-excludecorrectlytaggednodes ### 📊 Changes **17 files changed** (+199 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `acls.go` (+19 -4) 📝 `acls_test.go` (+92 -12) 📝 `acls_types.go` (+5 -5) 📝 `api.go` (+9 -2) 📝 `app.go` (+16 -6) 📝 `cmd/headscale/cli/api_key.go` (+3 -1) 📝 `cmd/headscale/cli/preauthkeys.go` (+3 -1) 📝 `cmd/headscale/cli/utils.go` (+4 -1) 📝 `grpcv1.go` (+1 -1) 📝 `integration_cli_test.go` (+7 -1) 📝 `integration_common_test.go` (+5 -3) 📝 `integration_embedded_derp_test.go` (+7 -1) 📝 `integration_general_test.go` (+7 -1) 📝 `machine_test.go` (+10 -2) 📝 `oidc.go` (+5 -1) 📝 `platform_config.go` (+5 -2) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md Fixes #563 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:50 +01:00
adam closed this issue 2025-12-29 02:30:50 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1586
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?