starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #700] [CLOSED] Temporary fix integration tests with dedicated Dockerfile #1582

New Issue
Closed
opened 2025-12-29 02:30:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/700
Author: @juanfont
Created: 7/31/2022
Status: ❌ Closed

Base: main ← Head: tmp-fix-integration-docker

📝 Commits (2)

  • 100f719 Temporary fix integration tests with dedicated Dockerfile
  • 5539ef1 Reduce the number of containers

📊 Changes

4 files changed (+25 additions, -4 deletions)

View changed files

➕ Dockerfile.tmp-integration (+21 -0)
📝 integration_cli_test.go (+1 -1)
📝 integration_embedded_derp_test.go (+1 -1)
📝 integration_test.go (+2 -2)

📄 Description

Currently our integration tests are broken due to the changes in the Dockerfile to add multi-arch support.

This is due to the lack of support in the dockertest library for the new BuildKit library from docker/moby. I have set a PR to dockertest to fix that https://github.com/ory/dockertest/pull/374

In the meantime, this PR adds a temporary extra Dockerfile in the old format, so we can keep working.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/700 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 7/31/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `tmp-fix-integration-docker` --- ### 📝 Commits (2) - [`100f719`](https://github.com/juanfont/headscale/commit/100f7190f3e82812fc9ef5ed191ef96d0881df91) Temporary fix integration tests with dedicated Dockerfile - [`5539ef1`](https://github.com/juanfont/headscale/commit/5539ef1f8f2e193beacd005a6f58c6120011b70a) Reduce the number of containers ### 📊 Changes **4 files changed** (+25 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `Dockerfile.tmp-integration` (+21 -0) 📝 `integration_cli_test.go` (+1 -1) 📝 `integration_embedded_derp_test.go` (+1 -1) 📝 `integration_test.go` (+2 -2) </details> ### 📄 Description Currently our integration tests are broken due to the changes in the Dockerfile to add multi-arch support. This is due to the lack of support in the dockertest library for the new BuildKit library from docker/moby. I have set a PR to dockertest to fix that https://github.com/ory/dockertest/pull/374 In the meantime, this PR adds a temporary extra Dockerfile in the old format, so we can keep working. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:49 +01:00
adam closed this issue 2025-12-29 02:30:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1582
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?