starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #689] [MERGED] Remove duplicate tags if sent by the client #1574

New Issue
Closed
opened 2025-12-29 02:30:44 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/689
Author: @restanrm
Created: 7/25/2022
Status: ✅ Merged
Merged: 7/28/2022
Merged by: @juanfont

Base: main ← Head: fix-duplicate-tags-returned-by-api

📝 Commits (3)

  • c46a34e fix(machine): remove duplicate in forcedTags
  • c90e862 fix(grpc): add more checks for tag validation
  • 2ab2b86 Merge branch 'main' into fix-duplicate-tags-returned-by-api

📊 Changes

5 files changed (+110 additions, -7 deletions)

View changed files

📝 grpcv1.go (+17 -5)
➕ grpcv1_test.go (+42 -0)
📝 integration_cli_test.go (+1 -1)
📝 machine.go (+7 -1)
📝 machine_test.go (+43 -0)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

As mentionned on discord by @linksysrouter, there was a possibility to add multiple times the same tags. This PR should remove this.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/689 **Author:** [@restanrm](https://github.com/restanrm) **Created:** 7/25/2022 **Status:** ✅ Merged **Merged:** 7/28/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `fix-duplicate-tags-returned-by-api` --- ### 📝 Commits (3) - [`c46a34e`](https://github.com/juanfont/headscale/commit/c46a34e6b848d7e5147f35b5a176db2d69c4d117) fix(machine): remove duplicate in forcedTags - [`c90e862`](https://github.com/juanfont/headscale/commit/c90e862460ab9b48d93e14f325efe9250ea2a0b5) fix(grpc): add more checks for tag validation - [`2ab2b86`](https://github.com/juanfont/headscale/commit/2ab2b8656b4d63273929d40d2a9811aff8002868) Merge branch 'main' into fix-duplicate-tags-returned-by-api ### 📊 Changes **5 files changed** (+110 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `grpcv1.go` (+17 -5) ➕ `grpcv1_test.go` (+42 -0) 📝 `integration_cli_test.go` (+1 -1) 📝 `machine.go` (+7 -1) 📝 `machine_test.go` (+43 -0) </details> ### 📄 Description - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md As mentionned on discord by @linksysrouter, there was a possibility to add multiple times the same tags. This PR should remove this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:44 +01:00
adam closed this issue 2025-12-29 02:30:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1574
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?