starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #685] [MERGED] Decompose OIDCCallback method #1570

New Issue
Closed
opened 2025-12-29 02:30:37 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/685
Author: @GrigoriyMikhalkin
Created: 7/21/2022
Status: ✅ Merged
Merged: 8/9/2022
Merged by: @juanfont

Base: main ← Head: oidc-refactoring

📝 Commits (4)

  • 00d2a44 decompose OIDCCallback method
  • a1e7e77 refactor OIDC callback aux functions
  • fc65ded Merge branch 'main' into oidc-refactoring
  • 8a9fe1d Merge branch 'main' into oidc-refactoring

📊 Changes

1 file changed (+224 additions, -83 deletions)

View changed files

📝 oidc.go (+224 -83)

📄 Description

gocyclo complains about OIDCCallback method complexity. This PR decomposes this method into smaller ones to simplify it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/685 **Author:** [@GrigoriyMikhalkin](https://github.com/GrigoriyMikhalkin) **Created:** 7/21/2022 **Status:** ✅ Merged **Merged:** 8/9/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `oidc-refactoring` --- ### 📝 Commits (4) - [`00d2a44`](https://github.com/juanfont/headscale/commit/00d2a447f4a11958d450d0d2b4c18dd4caa1e234) decompose OIDCCallback method - [`a1e7e77`](https://github.com/juanfont/headscale/commit/a1e7e771cecfbcd988c340e1e8fd1d6cd5a5d467) refactor OIDC callback aux functions - [`fc65ded`](https://github.com/juanfont/headscale/commit/fc65ded2d50312571739e18b649a150080a046d3) Merge branch 'main' into oidc-refactoring - [`8a9fe1d`](https://github.com/juanfont/headscale/commit/8a9fe1da4b850e3d82bcf57b3fd5c915c0c3be2e) Merge branch 'main' into oidc-refactoring ### 📊 Changes **1 file changed** (+224 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `oidc.go` (+224 -83) </details> ### 📄 Description `gocyclo` complains about `OIDCCallback` method complexity. This PR decomposes this method into smaller ones to simplify it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:37 +01:00
adam closed this issue 2025-12-29 02:30:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1570
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?