starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #667] [MERGED] Make integration tests retry on failure. #1561

New Issue
Closed
opened 2025-12-29 02:30:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/667
Author: @kradalby
Created: 6/27/2022
Status: ✅ Merged
Merged: 6/27/2022
Merged by: @juanfont

Base: main ← Head: rerun-docker

📝 Commits (5)

  • 911c5bd Make saving logs from tests an option (default false)
  • 8cae4f8 Fail tests instead of fatal
  • 3777de7 Use failnow for cli tests aswell
  • 32a6151 Rerun integration tests 5 times if error
  • 566b8c3 Fix issue were dockertest fails to start because of container mismatch

📊 Changes

5 files changed (+145 additions, -44 deletions)

View changed files

📝 .github/workflows/test-integration.yml (+6 -1)
📝 integration_cli_test.go (+9 -4)
📝 integration_common_test.go (+30 -1)
📝 integration_embedded_derp_test.go (+50 -19)
📝 integration_test.go (+50 -19)

📄 Description

This PR aims to harden the integration tests a bit so they can be rerun in the same environment on failure. In addition, we will let them rerun 5 times to try to allow us to not have to pay attention to them and rerun manually.

It should also make them a bit more consistent when running locally.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/667 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 6/27/2022 **Status:** ✅ Merged **Merged:** 6/27/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `rerun-docker` --- ### 📝 Commits (5) - [`911c5bd`](https://github.com/juanfont/headscale/commit/911c5bddce34b3474e4915fab5e1ed43fbe33978) Make saving logs from tests an option (default false) - [`8cae4f8`](https://github.com/juanfont/headscale/commit/8cae4f80d79a5baeccd2f41e4d09c1faa17b6f18) Fail tests instead of fatal - [`3777de7`](https://github.com/juanfont/headscale/commit/3777de7133ebf0cb55c6c1820df264a60544e403) Use failnow for cli tests aswell - [`32a6151`](https://github.com/juanfont/headscale/commit/32a6151df95c38eb58ca53ea95609474f6b164ef) Rerun integration tests 5 times if error - [`566b8c3`](https://github.com/juanfont/headscale/commit/566b8c3df34575fbf2fbd0d340059905c87616b2) Fix issue were dockertest fails to start because of container mismatch ### 📊 Changes **5 files changed** (+145 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yml` (+6 -1) 📝 `integration_cli_test.go` (+9 -4) 📝 `integration_common_test.go` (+30 -1) 📝 `integration_embedded_derp_test.go` (+50 -19) 📝 `integration_test.go` (+50 -19) </details> ### 📄 Description This PR aims to harden the integration tests a bit so they can be rerun in the same environment on failure. In addition, we will let them rerun 5 times to try to allow us to not have to pay attention to them and rerun manually. It should also make them a bit more consistent when running locally. - [ ] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:35 +01:00
adam closed this issue 2025-12-29 02:30:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?