starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 20:53:29 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #658] [MERGED] Quick fix to segfault on CLI when Headscale is not running #1557

New Issue
Closed
opened 2025-12-29 02:30:34 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/658
Author: @juanfont
Created: 6/22/2022
Status: ✅ Merged
Merged: 6/26/2022
Merged by: @kradalby

Base: main ← Head: fix-segfault-when-not-runner

📝 Commits (5)

  • c8378e8 Quick fix to segfault on CLI when Headscale is not running (fix #652)
  • 647972c Merge branch 'main' into fix-segfault-when-not-runner
  • 72d1d26 Update cmd/headscale/cli/utils.go
  • 34f489b Update cmd/headscale/cli/utils.go
  • f2f4c3f Merge branch 'main' into fix-segfault-when-not-runner

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 cmd/headscale/cli/utils.go (+2 -0)

📄 Description

When we pass --output json or similar we suppress all the logs -which also deactivates the call to os.Exit when doing Fatal().

This is a quick fix for #652.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/658 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 6/22/2022 **Status:** ✅ Merged **Merged:** 6/26/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix-segfault-when-not-runner` --- ### 📝 Commits (5) - [`c8378e8`](https://github.com/juanfont/headscale/commit/c8378e8b7dd66009ef3e36729875190c35fdc0df) Quick fix to segfault on CLI when Headscale is not running (fix #652) - [`647972c`](https://github.com/juanfont/headscale/commit/647972c7cf6defe5dc9980042b970ce03b3b1a06) Merge branch 'main' into fix-segfault-when-not-runner - [`72d1d26`](https://github.com/juanfont/headscale/commit/72d1d2630e720c42470bd12af9ab8f82cb084c72) Update cmd/headscale/cli/utils.go - [`34f489b`](https://github.com/juanfont/headscale/commit/34f489b1f43e6e25b269f4ad931285e76b7541b6) Update cmd/headscale/cli/utils.go - [`f2f4c3f`](https://github.com/juanfont/headscale/commit/f2f4c3f6844bdcee54270119ad9b04b9a141cc72) Merge branch 'main' into fix-segfault-when-not-runner ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/utils.go` (+2 -0) </details> ### 📄 Description When we pass `--output json` or similar we suppress all the logs -which also deactivates the call to `os.Exit` when doing Fatal(). This is a quick fix for #652. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:34 +01:00
adam closed this issue 2025-12-29 02:30:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1557
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?