starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #651] [MERGED] add timeout for http shutdown, add db disconnect #1554

New Issue
Closed
opened 2025-12-29 02:30:33 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/651
Author: @iSchluff
Created: 6/17/2022
Status: ✅ Merged
Merged: 6/26/2022
Merged by: @kradalby

Base: main ← Head: fix/db-shutdown

📝 Commits (5)

  • 735440d add timeout for http shutdown, add db disconnect
  • 8111b0a update changelog
  • 9707b1f Merge branch 'main' into fix/db-shutdown
  • 0fa943e Update CHANGELOG.md
  • 4637400 Update CHANGELOG.md

📊 Changes

2 files changed (+30 additions, -9 deletions)

View changed files

📝 CHANGELOG.md (+2 -1)
📝 app.go (+28 -8)

📄 Description

Does not fix broken graceful shutdown, but does limit it with a timeout which prevents sigkill by a service manager on stop.
Also close db connections explicitely to allow running queries to complete.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/651 **Author:** [@iSchluff](https://github.com/iSchluff) **Created:** 6/17/2022 **Status:** ✅ Merged **Merged:** 6/26/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix/db-shutdown` --- ### 📝 Commits (5) - [`735440d`](https://github.com/juanfont/headscale/commit/735440d1a34ff9b3de679df4bc085133c684c9ef) add timeout for http shutdown, add db disconnect - [`8111b0a`](https://github.com/juanfont/headscale/commit/8111b0aa834afc32d7852e7c1663b70b2d939e18) update changelog - [`9707b1f`](https://github.com/juanfont/headscale/commit/9707b1f5409b4e06c604a783048047d249437be8) Merge branch 'main' into fix/db-shutdown - [`0fa943e`](https://github.com/juanfont/headscale/commit/0fa943e4b74c394f73eef06df9c3402810b90f6c) Update CHANGELOG.md - [`4637400`](https://github.com/juanfont/headscale/commit/4637400d2916be712f22e0ed48c2f03769687b85) Update CHANGELOG.md ### 📊 Changes **2 files changed** (+30 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -1) 📝 `app.go` (+28 -8) </details> ### 📄 Description Does not fix broken graceful shutdown, but does limit it with a timeout which prevents sigkill by a service manager on stop. Also close db connections explicitely to allow running queries to complete. - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:33 +01:00
adam closed this issue 2025-12-29 02:30:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1554
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?