starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #648] [MERGED] Send Online field of tailcfg.Node based on LastSeen #1552

New Issue
Closed
opened 2025-12-29 02:30:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/648
Author: @juanfont
Created: 6/16/2022
Status: ✅ Merged
Merged: 6/16/2022
Merged by: @juanfont

Base: main ← Head: show-nodes-online

📝 Commits (3)

  • 66fffd6 Send Online field of tailcfg.Node based on LastSeen
  • 1e4678c Updated changelog
  • bfa9ed8 Merge branch 'main' into show-nodes-online

📊 Changes

2 files changed (+6 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 machine.go (+5 -0)

📄 Description

Nodes were permantly shown offline because we are not sending the Online field of Node. Even when we are communicating from another client.

image

This commit fixes it based on LastSeen with keepAliveInternal. Simple :)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/648 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 6/16/2022 **Status:** ✅ Merged **Merged:** 6/16/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `show-nodes-online` --- ### 📝 Commits (3) - [`66fffd6`](https://github.com/juanfont/headscale/commit/66fffd69ced2e5080b3a8dc22c5422b792d9289f) Send Online field of tailcfg.Node based on LastSeen - [`1e4678c`](https://github.com/juanfont/headscale/commit/1e4678c02feeee11e1462dd21e371da43c4254d9) Updated changelog - [`bfa9ed8`](https://github.com/juanfont/headscale/commit/bfa9ed814d7402d50bc8d8ede64c7417dd58c855) Merge branch 'main' into show-nodes-online ### 📊 Changes **2 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `machine.go` (+5 -0) </details> ### 📄 Description Nodes were permantly shown offline because we are not sending the `Online` field of Node. Even when we are communicating from another client. ![image](https://user-images.githubusercontent.com/181059/174123872-7725310f-6424-408b-8eab-fa9e34e984cb.png) This commit fixes it based on LastSeen with keepAliveInternal. Simple :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:32 +01:00
adam closed this issue 2025-12-29 02:30:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?