starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #639] [MERGED] Fix obtuse "ephemeral_node_inactivity_timeout" error #1547

New Issue
Closed
opened 2025-12-29 02:30:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/639
Author: @kradalby
Created: 6/12/2022
Status: ✅ Merged
Merged: 6/12/2022
Merged by: @kradalby

Base: main ← Head: ephemeral-error-msg

📝 Commits (6)

  • 95824ac MOve ephemeral inactivity config check to all the other config check
  • fd3a1c1 Add a default to ephemeral_node_inactivity_timeout
  • c95bce4 Update changelog
  • 76195bb Add warn if configuration could not be found
  • 7bd07e3 Merge branch 'main' into ephemeral-error-msg
  • 8650328 Remove debug output, it runs before we disable it

📊 Changes

3 files changed (+16 additions, -17 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 cmd/headscale/cli/utils.go (+0 -17)
📝 config.go (+15 -0)

📄 Description

This fixes #251

This PR will:

  • Move the configuration check for ephemeral_node_inactivity_timeout to where it should be
  • Set a default for ephemeral_node_inactivity_timeout
  • Add a warn if configuration could not be found.
  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/639 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 6/12/2022 **Status:** ✅ Merged **Merged:** 6/12/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `ephemeral-error-msg` --- ### 📝 Commits (6) - [`95824ac`](https://github.com/juanfont/headscale/commit/95824ac2ec1d029a137e9c7eb4b1e93525722296) MOve ephemeral inactivity config check to all the other config check - [`fd3a1c1`](https://github.com/juanfont/headscale/commit/fd3a1c13e31586a7f4e38ec5d6209cfae6162df6) Add a default to ephemeral_node_inactivity_timeout - [`c95bce4`](https://github.com/juanfont/headscale/commit/c95bce4aea6cdd104a5f0119cfaa80606850424f) Update changelog - [`76195bb`](https://github.com/juanfont/headscale/commit/76195bb3ac98dfdd38aea37ef6e11cb36542019d) Add warn if configuration could not be found - [`7bd07e3`](https://github.com/juanfont/headscale/commit/7bd07e3b9bff8c5f150ebe443515042aad429a50) Merge branch 'main' into ephemeral-error-msg - [`8650328`](https://github.com/juanfont/headscale/commit/86503289226265f719e98490d26d5f4110a9108f) Remove debug output, it runs before we disable it ### 📊 Changes **3 files changed** (+16 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `cmd/headscale/cli/utils.go` (+0 -17) 📝 `config.go` (+15 -0) </details> ### 📄 Description This fixes #251 This PR will: - Move the configuration check for `ephemeral_node_inactivity_timeout` to where it should be - Set a default for `ephemeral_node_inactivity_timeout` - Add a warn if configuration could not be found. <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [x] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:31 +01:00
adam closed this issue 2025-12-29 02:30:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1547
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?