[PR #610] [MERGED] some GOOS do not support pie build, detect in makefile and fall back to non-pie build #1521

Closed
opened 2025-12-29 02:30:25 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/610
Author: @huskyii
Created: 6/4/2022
Status: Merged
Merged: 6/4/2022
Merged by: @kradalby

Base: mainHead: fix_pie_build


📝 Commits (1)

  • 2201ec8 some GOOS do not support pie build, detect in makefile and fall back to non-pie build

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 Makefile (+8 -1)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/610 **Author:** [@huskyii](https://github.com/huskyii) **Created:** 6/4/2022 **Status:** ✅ Merged **Merged:** 6/4/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix_pie_build` --- ### 📝 Commits (1) - [`2201ec8`](https://github.com/juanfont/headscale/commit/2201ec890542f2185961edbea38702a85a029293) some GOOS do not support pie build, detect in makefile and fall back to non-pie build ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+8 -1) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:25 +01:00
adam closed this issue 2025-12-29 02:30:25 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1521