starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #602] [MERGED] Fix forced Tags with legitimate tagOwners #1516

New Issue
Closed
opened 2025-12-29 02:30:23 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:23 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/602
Author: @iSchluff
Created: 6/1/2022
Status: ✅ Merged
Merged: 6/2/2022
Merged by: @kradalby

Base: main ← Head: fix/forced-tags-with-tagOwner

📝 Commits (1)

  • 6dccfee Fix forced Tags with legitimate tagOwners

📊 Changes

2 files changed (+58 additions, -12 deletions)

View changed files

📝 acls.go (+12 -12)
📝 acls_test.go (+46 -0)

📄 Description

Basically always check whether a tag is forced instead of just on tagOwners failure. Also replace loops with contains.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/602 **Author:** [@iSchluff](https://github.com/iSchluff) **Created:** 6/1/2022 **Status:** ✅ Merged **Merged:** 6/2/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix/forced-tags-with-tagOwner` --- ### 📝 Commits (1) - [`6dccfee`](https://github.com/juanfont/headscale/commit/6dccfee86229d67f5341851289b4c407be0625ea) Fix forced Tags with legitimate tagOwners ### 📊 Changes **2 files changed** (+58 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `acls.go` (+12 -12) 📝 `acls_test.go` (+46 -0) </details> ### 📄 Description Basically always check whether a tag is forced instead of just on tagOwners failure. Also replace loops with contains. <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:23 +01:00
adam closed this issue 2025-12-29 02:30:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?