starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #597] [MERGED] Check errors for Database calls #1511

New Issue
Closed
opened 2025-12-29 02:30:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/597
Author: @kradalby
Created: 5/30/2022
Status: ✅ Merged
Merged: 6/3/2022
Merged by: @kradalby

Base: main ← Head: db-error-handling

📝 Commits (7)

  • 52cc3bc Check all errors for db.Save
  • a1837a4 Merge branch 'main' into db-error-handling
  • a09633e Check errors of more database calls
  • 5ecfbba Fix pointer in machine save call
  • 0676aa1 Merge branch 'main' into db-error-handling
  • a19af04 Fix errors introduced by merge
  • 6f6fb4d Merge branch 'main' into db-error-handling

📊 Changes

8 files changed (+79 additions, -18 deletions)

View changed files

📝 api.go (+11 -2)
📝 api_key.go (+4 -1)
📝 db.go (+3 -1)
📝 integration_cli_test.go (+1 -1)
📝 machine.go (+29 -8)
📝 poll.go (+14 -1)
📝 preauth_keys.go (+11 -3)
📝 routes.go (+6 -1)

📄 Description

This PR addresses the concerns raised in #233

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/597 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 5/30/2022 **Status:** ✅ Merged **Merged:** 6/3/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `db-error-handling` --- ### 📝 Commits (7) - [`52cc3bc`](https://github.com/juanfont/headscale/commit/52cc3bc8eb8e50c2d4bd4e420a54d845e8872dcc) Check all errors for db.Save - [`a1837a4`](https://github.com/juanfont/headscale/commit/a1837a4d69285f7f11fd45746c2151c3c4b74de1) Merge branch 'main' into db-error-handling - [`a09633e`](https://github.com/juanfont/headscale/commit/a09633e859300fbf00c079f7ec7e284d37081b7e) Check errors of more database calls - [`5ecfbba`](https://github.com/juanfont/headscale/commit/5ecfbbaf5d423921b6d9a2935cb337734fa06d85) Fix pointer in machine save call - [`0676aa1`](https://github.com/juanfont/headscale/commit/0676aa11a9e4751bce11c7267f32dd97294b4e3a) Merge branch 'main' into db-error-handling - [`a19af04`](https://github.com/juanfont/headscale/commit/a19af0458286a4f18bcd0d33d797d19e4c0a6853) Fix errors introduced by merge - [`6f6fb4d`](https://github.com/juanfont/headscale/commit/6f6fb4dcd667795a189eae39f50a0b7a1e666580) Merge branch 'main' into db-error-handling ### 📊 Changes **8 files changed** (+79 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `api.go` (+11 -2) 📝 `api_key.go` (+4 -1) 📝 `db.go` (+3 -1) 📝 `integration_cli_test.go` (+1 -1) 📝 `machine.go` (+29 -8) 📝 `poll.go` (+14 -1) 📝 `preauth_keys.go` (+11 -3) 📝 `routes.go` (+6 -1) </details> ### 📄 Description This PR addresses the concerns raised in #233 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:21 +01:00
adam closed this issue 2025-12-29 02:30:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1511
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?