starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #569] [MERGED] Command for moving nodes between namespaces #1488

New Issue
Closed
opened 2025-12-29 02:30:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:15 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/569
Author: @kazauwa
Created: 5/1/2022
Status: ✅ Merged
Merged: 5/2/2022
Merged by: @kradalby

Base: main ← Head: 362-add-move-command

📝 Commits (9)

  • 47c72a4 add rpc method for moving node
  • bc055ed add command for moving node between namespaces
  • 62c780a update changelog
  • 4e686f8 add unit test
  • 1b3a7bb apply styling fixes
  • 6ba68d1 correctly update machine namespace
  • 12d8f0f remove redundant lines of code, fix response when output is not plain text
  • e279224 add integrations tests
  • b9ea83f check that new command does not break nodes list output

📊 Changes

13 files changed (+827 additions, -153 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 cmd/headscale/cli/nodes.go (+89 -0)
📝 gen/go/headscale/v1/headscale.pb.go (+107 -95)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+117 -0)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+36 -4)
📝 gen/go/headscale/v1/machine.pb.go (+190 -51)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+45 -0)
📝 grpcv1.go (+17 -0)
📝 integration_cli_test.go (+169 -0)
📝 namespaces.go (+4 -2)
📝 namespaces_test.go (+37 -0)
📝 proto/headscale/v1/headscale.proto (+6 -0)
📝 proto/headscale/v1/machine.proto (+9 -1)

📄 Description

Added command for moving nodes between namespaces (see #362)

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/569 **Author:** [@kazauwa](https://github.com/kazauwa) **Created:** 5/1/2022 **Status:** ✅ Merged **Merged:** 5/2/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `362-add-move-command` --- ### 📝 Commits (9) - [`47c72a4`](https://github.com/juanfont/headscale/commit/47c72a4e2e2f922ed1522555732dbc57dea8216c) add rpc method for moving node - [`bc055ed`](https://github.com/juanfont/headscale/commit/bc055edf12f2e8bd8e7286fe3ecee078de6037a6) add command for moving node between namespaces - [`62c780a`](https://github.com/juanfont/headscale/commit/62c780a448fd518aa2ab59e6ce832495dc7ed266) update changelog - [`4e686f8`](https://github.com/juanfont/headscale/commit/4e686f8b77b70c94a67e3487db4f9b39eeb94ea9) add unit test - [`1b3a7bb`](https://github.com/juanfont/headscale/commit/1b3a7bbf03473a5f635ffae7182fae166ca1fcd9) apply styling fixes - [`6ba68d1`](https://github.com/juanfont/headscale/commit/6ba68d150cdc0233c13486c2952af5808e130b75) correctly update machine namespace - [`12d8f0f`](https://github.com/juanfont/headscale/commit/12d8f0f4b0dce277bd51e2a23ce32399b9d11464) remove redundant lines of code, fix response when output is not plain text - [`e279224`](https://github.com/juanfont/headscale/commit/e279224484b7d2c0ac0e71df01fb67ae772bdcb8) add integrations tests - [`b9ea83f`](https://github.com/juanfont/headscale/commit/b9ea83fed8861016bdedd52dffffc78c97d65104) check that new command does not break nodes list output ### 📊 Changes **13 files changed** (+827 additions, -153 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `cmd/headscale/cli/nodes.go` (+89 -0) 📝 `gen/go/headscale/v1/headscale.pb.go` (+107 -95) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+117 -0) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+36 -4) 📝 `gen/go/headscale/v1/machine.pb.go` (+190 -51) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+45 -0) 📝 `grpcv1.go` (+17 -0) 📝 `integration_cli_test.go` (+169 -0) 📝 `namespaces.go` (+4 -2) 📝 `namespaces_test.go` (+37 -0) 📝 `proto/headscale/v1/headscale.proto` (+6 -0) 📝 `proto/headscale/v1/machine.proto` (+9 -1) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> Added command for moving nodes between namespaces (see [#362](https://github.com/juanfont/headscale/issues/362)) - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [x] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:15 +01:00
adam closed this issue 2025-12-29 02:30:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?