starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #566] [MERGED] Do not setLastStateChangeToNow every expireEphemeralNodesWorker call #1485

New Issue
Closed
opened 2025-12-29 02:30:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:15 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/566
Author: @juanfont
Created: 4/30/2022
Status: ✅ Merged
Merged: 4/30/2022
Merged by: @kradalby

Base: main ← Head: fix-spurious-updates

📝 Commits (2)

  • 843e2bd Do not setLastStateChangeToNow every 5 seconds
  • 03659c4 Updated changelog

📊 Changes

2 files changed (+6 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 app.go (+5 -1)

📄 Description

setLastStateChangeToNow was being called everytime we run expireEphemeralNodesWorker, even if there are no nodes to expire.

  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/566 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 4/30/2022 **Status:** ✅ Merged **Merged:** 4/30/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix-spurious-updates` --- ### 📝 Commits (2) - [`843e2bd`](https://github.com/juanfont/headscale/commit/843e2bd9b63872d18ff0cfbe6e121aeb1a4d3076) Do not setLastStateChangeToNow every 5 seconds - [`03659c4`](https://github.com/juanfont/headscale/commit/03659c417507149df7dc294669077ad713063e6a) Updated changelog ### 📊 Changes **2 files changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `app.go` (+5 -1) </details> ### 📄 Description `setLastStateChangeToNow` was being called everytime we run `expireEphemeralNodesWorker`, even if there are no nodes to expire. - [x] updated CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:15 +01:00
adam closed this issue 2025-12-29 02:30:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?