starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #557] [MERGED] remove necessary buf installation #1480

New Issue
Closed
opened 2025-12-29 02:30:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/557
Author: @mpldr
Created: 4/21/2022
Status: ✅ Merged
Merged: 4/22/2022
Merged by: @kradalby

Base: main ← Head: remove-buf-installation

📝 Commits (2)

  • 3023323 remove necessary buf installation
  • 613dc61 Merge branch 'main' into remove-buf-installation

📊 Changes

4 files changed (+84 additions, -186 deletions)

View changed files

📝 Makefile (+2 -2)
📝 go.mod (+24 -9)
📝 go.sum (+57 -175)
📝 tools.go (+1 -0)

📄 Description

This commit adds buf as a regular dependency and go running it instead
of requiring installing buf to one's own GOBIN.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

This also has the added advantage that every user is always using the same version.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/557 **Author:** [@mpldr](https://github.com/mpldr) **Created:** 4/21/2022 **Status:** ✅ Merged **Merged:** 4/22/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `remove-buf-installation` --- ### 📝 Commits (2) - [`3023323`](https://github.com/juanfont/headscale/commit/30233235284dcccc6b21ad988c480426ea3b27d4) remove necessary buf installation - [`613dc61`](https://github.com/juanfont/headscale/commit/613dc6133967b67d171ed625911a1b6b6dee8dd9) Merge branch 'main' into remove-buf-installation ### 📊 Changes **4 files changed** (+84 additions, -186 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+2 -2) 📝 `go.mod` (+24 -9) 📝 `go.sum` (+57 -175) 📝 `tools.go` (+1 -0) </details> ### 📄 Description This commit adds buf as a regular dependency and go running it instead of requiring installing buf to one's own GOBIN. <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> This also has the added advantage that every user is always using the same version. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:13 +01:00
adam closed this issue 2025-12-29 02:30:13 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1480
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?