starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #544] [MERGED] Makefile improvements #1471

New Issue
Closed
opened 2025-12-29 02:30:11 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/544
Author: @mpldr
Created: 4/11/2022
Status: ✅ Merged
Merged: 4/12/2022
Merged by: @kradalby

Base: main ← Head: makefile-improvements

📝 Commits (5)

  • 1f43c39 replaced version-at-commit script with git-describe call
  • c312f8b set up Makefile for reproducible builds
  • 3abdc87 Merge branch 'main' into makefile-improvements
  • 8601dd1 fixed CGO disabling
  • 93682ab Merge branch 'main' into makefile-improvements

📊 Changes

2 files changed (+2 additions, -41 deletions)

View changed files

📝 Makefile (+2 -2)
➖ scripts/version-at-commit.sh (+0 -39)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

replacing the version-at-commit script allows having an identifiable version even for dev-builds and does not rely on external logic to generate a version

changes to the Makefile have been made to remove buildpaths from the compiled binary and to harden it

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/544 **Author:** [@mpldr](https://github.com/mpldr) **Created:** 4/11/2022 **Status:** ✅ Merged **Merged:** 4/12/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `makefile-improvements` --- ### 📝 Commits (5) - [`1f43c39`](https://github.com/juanfont/headscale/commit/1f43c39f93aeb4018b6481365369e07022f09341) replaced version-at-commit script with git-describe call - [`c312f8b`](https://github.com/juanfont/headscale/commit/c312f8bf4a8e21284b1a1b41c414ad957142b469) set up Makefile for reproducible builds - [`3abdc87`](https://github.com/juanfont/headscale/commit/3abdc870d8b49485240c48be04216a683636bd99) Merge branch 'main' into makefile-improvements - [`8601dd1`](https://github.com/juanfont/headscale/commit/8601dd1f4235c52d7f123c7bf802ab2be865978f) fixed CGO disabling - [`93682ab`](https://github.com/juanfont/headscale/commit/93682ab70880db298146f0db55dcdddb0636d14c) Merge branch 'main' into makefile-improvements ### 📊 Changes **2 files changed** (+2 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+2 -2) ➖ `scripts/version-at-commit.sh` (+0 -39) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> replacing the version-at-commit script allows having an identifiable version even for dev-builds and does not rely on external logic to generate a version changes to the Makefile have been made to remove buildpaths from the compiled binary and to harden it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:11 +01:00
adam closed this issue 2025-12-29 02:30:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1471
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?