starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #542] [MERGED] fixed the issue of sending on closed channel #1468

New Issue
Closed
opened 2025-12-29 02:30:11 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/542
Author: @mpldr
Created: 4/10/2022
Status: ✅ Merged
Merged: 4/11/2022
Merged by: @kradalby

Base: main ← Head: issue-342-send-on-closed-channel

📝 Commits (2)

  • 22dd61d fixed the issue of sending on closed channel
  • 9f03a01 updated changelog

📊 Changes

2 files changed (+46 additions, -23 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 poll.go (+45 -23)

📄 Description

This commit fixes the issue of headscale crashing after sending on a
closed channel by moving the channel close to the sender side, instead
of the creator. closeChanWithLog is also implemented with generics now.

Signed-off-by: Moritz Poldrack git@moritz.sh

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #342

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/542 **Author:** [@mpldr](https://github.com/mpldr) **Created:** 4/10/2022 **Status:** ✅ Merged **Merged:** 4/11/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `issue-342-send-on-closed-channel` --- ### 📝 Commits (2) - [`22dd61d`](https://github.com/juanfont/headscale/commit/22dd61d8497165c28d51109cf7f9d6b5da404a6d) fixed the issue of sending on closed channel - [`9f03a01`](https://github.com/juanfont/headscale/commit/9f03a012fb7faa8cde35ba39addfb287b2ffa5cd) updated changelog ### 📊 Changes **2 files changed** (+46 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `poll.go` (+45 -23) </details> ### 📄 Description This commit fixes the issue of headscale crashing after sending on a closed channel by moving the channel close to the sender side, instead of the creator. closeChanWithLog is also implemented with generics now. Signed-off-by: Moritz Poldrack <git@moritz.sh> <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> Fixes #342 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:11 +01:00
adam closed this issue 2025-12-29 02:30:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1468
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?