starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #519] [MERGED] Fix labels cardinality error when registering unknown pre-auth key #1456

New Issue
Closed
opened 2025-12-29 02:30:08 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:08 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/519
Author: @hdhoang
Created: 3/21/2022
Status: ✅ Merged
Merged: 3/25/2022
Merged by: @juanfont

Base: main ← Head: pak-counter

📝 Commits (1)

  • 52fd13b Fix labels cardinality error when registering unknown pre-auth key

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 api.go (+1 -1)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

I fat-fingered an auth-key, and observed this error:

2022-03-21T02:57:35Z INF New machine machine=localhost-live
2022-03-21T02:57:35Z DBG Processing auth key for localhost-live func=handleAuthKey machine=localhost-live
2022-03-21T02:57:35Z ERR ../home/runner/work/headscale/headscale/api.go:544 > Failed authentication via AuthKey error="AuthKey not found" func=handleAuthKey machine=localhost-live
2022-03-21T02:57:35Z ERR ../home/runner/work/headscale/headscale/api.go:567 > Failed authentication via AuthKey func=handleAuthKey machine=localhost-live


[GIN-debug] [WARNING] Headers were already written. Wanted to override status code 401 with 500
2022/03/21 09:57:35 [Recovery] 2022/03/21 - 09:57:35 panic recovered:
POST /machine/snip.machine.key HTTP/1.0
Host: snip-host
Connection: close
Connection: close
Content-Length: 867
User-Agent: Go-http-client/1.1
X-Forwarded-For: 123.snip
X-Forwarded-Proto: https
X-Real-Ip: 123.snip


inconsistent label cardinality: expected 4 label values but got 3 in []string{"new", "authkey", "error"}
/home/runner/go/pkg/mod/github.com/prometheus/client_golang@v1.12.1/prometheus/counter.go:252 (0xb9fc04)
/home/runner/work/headscale/headscale/api.go:576 (0xf11bb6)
/home/runner/work/headscale/headscale/api.go:132 (0xf0e8c7)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/context.go:168 (0x9b4281)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/recovery.go:99 (0x9b426c)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/context.go:168 (0x9b33a6)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/logger.go:241 (0x9b3389)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/context.go:168 (0x9b2470)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/gin.go:555 (0x9b20d8)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/gin.go:511 (0x9b1c11)
/opt/hostedtoolcache/go/1.18.0/x64/src/net/http/server.go:2916 (0x7c3b9a)
/opt/hostedtoolcache/go/1.18.0/x64/src/net/http/server.go:1966 (0x7beb96)
/opt/hostedtoolcache/go/1.18.0/x64/src/runtime/asm_amd64.s:1571 (0x467700)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/519 **Author:** [@hdhoang](https://github.com/hdhoang) **Created:** 3/21/2022 **Status:** ✅ Merged **Merged:** 3/25/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `pak-counter` --- ### 📝 Commits (1) - [`52fd13b`](https://github.com/juanfont/headscale/commit/52fd13bfc4a689f93d2ecbbfcf1ea38e01c7e21a) Fix labels cardinality error when registering unknown pre-auth key ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `api.go` (+1 -1) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> I fat-fingered an auth-key, and observed this error: ``` 2022-03-21T02:57:35Z INF New machine machine=localhost-live 2022-03-21T02:57:35Z DBG Processing auth key for localhost-live func=handleAuthKey machine=localhost-live 2022-03-21T02:57:35Z ERR ../home/runner/work/headscale/headscale/api.go:544 > Failed authentication via AuthKey error="AuthKey not found" func=handleAuthKey machine=localhost-live 2022-03-21T02:57:35Z ERR ../home/runner/work/headscale/headscale/api.go:567 > Failed authentication via AuthKey func=handleAuthKey machine=localhost-live [GIN-debug] [WARNING] Headers were already written. Wanted to override status code 401 with 500 2022/03/21 09:57:35 [Recovery] 2022/03/21 - 09:57:35 panic recovered: POST /machine/snip.machine.key HTTP/1.0 Host: snip-host Connection: close Connection: close Content-Length: 867 User-Agent: Go-http-client/1.1 X-Forwarded-For: 123.snip X-Forwarded-Proto: https X-Real-Ip: 123.snip inconsistent label cardinality: expected 4 label values but got 3 in []string{"new", "authkey", "error"} /home/runner/go/pkg/mod/github.com/prometheus/client_golang@v1.12.1/prometheus/counter.go:252 (0xb9fc04) /home/runner/work/headscale/headscale/api.go:576 (0xf11bb6) /home/runner/work/headscale/headscale/api.go:132 (0xf0e8c7) /home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/context.go:168 (0x9b4281) /home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/recovery.go:99 (0x9b426c) /home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/context.go:168 (0x9b33a6) /home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/logger.go:241 (0x9b3389) /home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/context.go:168 (0x9b2470) /home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/gin.go:555 (0x9b20d8) /home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.7.7/gin.go:511 (0x9b1c11) /opt/hostedtoolcache/go/1.18.0/x64/src/net/http/server.go:2916 (0x7c3b9a) /opt/hostedtoolcache/go/1.18.0/x64/src/net/http/server.go:1966 (0x7beb96) /opt/hostedtoolcache/go/1.18.0/x64/src/runtime/asm_amd64.s:1571 (0x467700) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:08 +01:00
adam closed this issue 2025-12-29 02:30:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1456
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?