starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #511] [MERGED] fix(oidc): Reset expiry for reauthentication #1450

New Issue
Closed
opened 2025-12-29 02:30:08 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:08 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/511
Author: @restanrm
Created: 3/18/2022
Status: ✅ Merged
Merged: 3/18/2022
Merged by: @kradalby

Base: main ← Head: fix-machine-registration-expired

📝 Commits (3)

  • 61ebb71 fix(oidc): Reset expiry for reauthentication
  • 882c0c3 chore(changelog): update changelog
  • b65bd5b Merge branch 'main' into fix-machine-registration-expired

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 oidc.go (+2 -1)

📄 Description

The previous code resetted the expiry time to be expired. So the machine was never reauthenticated

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

closes #508

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/511 **Author:** [@restanrm](https://github.com/restanrm) **Created:** 3/18/2022 **Status:** ✅ Merged **Merged:** 3/18/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix-machine-registration-expired` --- ### 📝 Commits (3) - [`61ebb71`](https://github.com/juanfont/headscale/commit/61ebb713f298564db76c43ef14046ed5d0b597ab) fix(oidc): Reset expiry for reauthentication - [`882c0c3`](https://github.com/juanfont/headscale/commit/882c0c34c11596e2442a4fb4ab2034323d437215) chore(changelog): update changelog - [`b65bd5b`](https://github.com/juanfont/headscale/commit/b65bd5baa8ee21fad27d11cde3bddfd7a8871de3) Merge branch 'main' into fix-machine-registration-expired ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `oidc.go` (+2 -1) </details> ### 📄 Description The previous code resetted the expiry time to be expired. So the machine was never reauthenticated <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md closes #508 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:08 +01:00
adam closed this issue 2025-12-29 02:30:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1450
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?