starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #498] [CLOSED] Machine rename support #1441

New Issue
Closed
opened 2025-12-29 02:30:06 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/498
Author: @bravechamp
Created: 3/13/2022
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (5)

  • 663e838 Nickname support
  • 9901d6b Ability to clear nickname
  • 60ee046 Normalize nickname before saving to database
  • c8aa653 Merge branch 'main' into main
  • 8845938 Merge branch 'main' into main

📊 Changes

10 files changed (+687 additions, -197 deletions)

View changed files

📝 cmd/headscale/cli/nodes.go (+57 -0)
📝 gen/go/headscale/v1/headscale.pb.go (+114 -101)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+119 -0)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+36 -0)
📝 gen/go/headscale/v1/machine.pb.go (+244 -95)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+48 -0)
📝 grpcv1.go (+22 -0)
📝 machine.go (+30 -1)
📝 proto/headscale/v1/headscale.proto (+6 -0)
📝 proto/headscale/v1/machine.proto (+11 -0)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Changes:

  • Machines can have nicknames
  • If nickname is set, it overrides Machine Name and new name will be used instead
  • Added nickname on nodes list output
  • New command nodes rename sets and clears nickname

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/498 **Author:** [@bravechamp](https://github.com/bravechamp) **Created:** 3/13/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`663e838`](https://github.com/juanfont/headscale/commit/663e8384a3bed7db57ec83fe8e2360295d9b4591) Nickname support - [`9901d6b`](https://github.com/juanfont/headscale/commit/9901d6b2e74f563fb3edaf86249f756c148588fd) Ability to clear nickname - [`60ee046`](https://github.com/juanfont/headscale/commit/60ee04674d4252bf28015e5091458956b5253081) Normalize nickname before saving to database - [`c8aa653`](https://github.com/juanfont/headscale/commit/c8aa653275800fda72c41c2a09ccd02bbd548cfd) Merge branch 'main' into main - [`8845938`](https://github.com/juanfont/headscale/commit/88459388810f868003bf2b737e593efc32d8eb93) Merge branch 'main' into main ### 📊 Changes **10 files changed** (+687 additions, -197 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/nodes.go` (+57 -0) 📝 `gen/go/headscale/v1/headscale.pb.go` (+114 -101) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+119 -0) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+36 -0) 📝 `gen/go/headscale/v1/machine.pb.go` (+244 -95) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+48 -0) 📝 `grpcv1.go` (+22 -0) 📝 `machine.go` (+30 -1) 📝 `proto/headscale/v1/headscale.proto` (+6 -0) 📝 `proto/headscale/v1/machine.proto` (+11 -0) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> Changes: - Machines can have nicknames - If nickname is set, it overrides Machine Name and new name will be used instead - Added nickname on `nodes list` output - New command `nodes rename` sets and clears nickname --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:06 +01:00
adam closed this issue 2025-12-29 02:30:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1441
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?