starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #495] [MERGED] Regression bug fix when re-authenticating machine with auth-key #1440

New Issue
Closed
opened 2025-12-29 02:30:06 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/495
Author: @mevansam
Created: 3/10/2022
Status: ✅ Merged
Merged: 3/10/2022
Merged by: @kradalby

Base: main ← Head: appbricks/main-bug-fix

📝 Commits (3)

📊 Changes

1 file changed (+48 additions, -27 deletions)

View changed files

📝 api.go (+48 -27)

📄 Description

This pull request fixes a regression bug https://github.com/juanfont/headscale/issues/489 where re-authenticating an expired machine (as a result of logout) resulted in a duplicate machine record. The fix simply refreshes the expired machine record to make it current.

This request updates https://github.com/juanfont/headscale/pull/490 based on review.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/495 **Author:** [@mevansam](https://github.com/mevansam) **Created:** 3/10/2022 **Status:** ✅ Merged **Merged:** 3/10/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `appbricks/main-bug-fix` --- ### 📝 Commits (3) - [`8b5e8b7`](https://github.com/juanfont/headscale/commit/8b5e8b7dfc2b8915cbb2172a0bdf579bbea5122a) Refresh expired machine on re-auth - closes #489 - [`af081e9`](https://github.com/juanfont/headscale/commit/af081e9fd3ff304d58893057d0a2902531fdc786) fixed lint errors - [`082a852`](https://github.com/juanfont/headscale/commit/082a852c5e946fe7e58f0a94a332372d923fa7b5) fixed linting recommendation ### 📊 Changes **1 file changed** (+48 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `api.go` (+48 -27) </details> ### 📄 Description This pull request fixes a regression bug https://github.com/juanfont/headscale/issues/489 where re-authenticating an expired machine (as a result of logout) resulted in a duplicate machine record. The fix simply refreshes the expired machine record to make it current. This request updates https://github.com/juanfont/headscale/pull/490 based on review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:06 +01:00
adam closed this issue 2025-12-29 02:30:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1440
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?