starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #486] [MERGED] Make register html template consistent with other endpoints #1434

New Issue
Closed
opened 2025-12-29 02:30:03 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:03 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/486
Author: @e-zk
Created: 3/8/2022
Status: ✅ Merged
Merged: 3/8/2022
Merged by: @kradalby

Base: main ← Head: main

📝 Commits (2)

  • c06689d fix: make register html/template consistent with other html
  • e54c508 Merge branch 'main' into main

📊 Changes

1 file changed (+13 additions, -14 deletions)

View changed files

📝 api.go (+13 -14)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Formatting change for consistency's sake to have /register have the same HTML structure as the /apple and /windows endpoints.

Does this need a changelog entry? It's a fairly minor, low priority change.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/486 **Author:** [@e-zk](https://github.com/e-zk) **Created:** 3/8/2022 **Status:** ✅ Merged **Merged:** 3/8/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`c06689d`](https://github.com/juanfont/headscale/commit/c06689dec15cf2642b30c38e7f661aafe8e02889) fix: make register html/template consistent with other html - [`e54c508`](https://github.com/juanfont/headscale/commit/e54c508c10e67f343e6fc8431e594749062dab98) Merge branch 'main' into main ### 📊 Changes **1 file changed** (+13 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `api.go` (+13 -14) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> Formatting change for consistency's sake to have `/register` have the same HTML structure as the `/apple` and `/windows` endpoints. Does this need a changelog entry? It's a fairly minor, low priority change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:03 +01:00
adam closed this issue 2025-12-29 02:30:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1434
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?