starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #387] [MERGED] Fix magic dns and uppercase letters #1420

New Issue
Closed
opened 2025-12-29 02:30:00 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/387
Author: @restanrm
Created: 3/4/2022
Status: ✅ Merged
Merged: 3/8/2022
Merged by: @kradalby

Base: main ← Head: fix-magic-dns-and-uppercase-letters

📝 Commits (8)

  • 44a5372 fix(poll): Normalize hostname
  • 6f172a6 fix(acls): remove dead error code
  • dcf3ea5 Merge branch 'main' into fix-magic-dns-and-uppercase-letters
  • 1114449 change: update name of method to check and normalize Domain name
  • 6cc8bbc feat(api): add normalisation at machine register step
  • f19c048 fix: change normalization function name
  • 2b68c90 chore: update changelog
  • 41efe98 fix: apply fmt and fix missing name changes

📊 Changes

7 files changed (+48 additions, -24 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 acls.go (+6 -7)
📝 api.go (+14 -1)
📝 namespaces.go (+7 -7)
📝 namespaces_test.go (+7 -7)
📝 oidc.go (+1 -1)
📝 poll.go (+12 -1)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • [] added unit tests
  • [] added integration tests
  • [] updated documentation if needed
  • [] updated CHANGELOG.md

This will fix #363 by applying normalization on the hostname. This normalization function will lowercase capital letters and replace forbidden chars. If it cannot find a solution it will raise an error on headscale server.

CAPITALNAME => capitalname
HOST Name 1 => host-name-1

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/387 **Author:** [@restanrm](https://github.com/restanrm) **Created:** 3/4/2022 **Status:** ✅ Merged **Merged:** 3/8/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix-magic-dns-and-uppercase-letters` --- ### 📝 Commits (8) - [`44a5372`](https://github.com/juanfont/headscale/commit/44a5372c531d8118a3b2b01167640003f8f16365) fix(poll): Normalize hostname - [`6f172a6`](https://github.com/juanfont/headscale/commit/6f172a6e4ccb71e94c4daa7617408e0b5dc16e92) fix(acls): remove dead error code - [`dcf3ea5`](https://github.com/juanfont/headscale/commit/dcf3ea567c143078bd30a1f39b9ac2a0c3cb43ae) Merge branch 'main' into fix-magic-dns-and-uppercase-letters - [`1114449`](https://github.com/juanfont/headscale/commit/11144496015a2ee6dfd80046aace3c5e68c3d12b) change: update name of method to check and normalize Domain name - [`6cc8bbc`](https://github.com/juanfont/headscale/commit/6cc8bbc24fb0666b68d3ea9ba44dab83ec0d69a8) feat(api): add normalisation at machine register step - [`f19c048`](https://github.com/juanfont/headscale/commit/f19c0485698b6e7a2131c7f4534e79a796962a62) fix: change normalization function name - [`2b68c90`](https://github.com/juanfont/headscale/commit/2b68c90778c89335bef35eb355aff432da9592db) chore: update changelog - [`41efe98`](https://github.com/juanfont/headscale/commit/41efe98953388f62120f7ea3f7d94d1cccb3de32) fix: apply fmt and fix missing name changes ### 📊 Changes **7 files changed** (+48 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `acls.go` (+6 -7) 📝 `api.go` (+14 -1) 📝 `namespaces.go` (+7 -7) 📝 `namespaces_test.go` (+7 -7) 📝 `oidc.go` (+1 -1) 📝 `poll.go` (+12 -1) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [] added unit tests - [] added integration tests - [] updated documentation if needed - [] updated CHANGELOG.md This will fix #363 by applying normalization on the hostname. This normalization function will lowercase capital letters and replace forbidden chars. If it cannot find a solution it will raise an error on headscale server. ``` CAPITALNAME => capitalname HOST Name 1 => host-name-1 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:00 +01:00
adam closed this issue 2025-12-29 02:30:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?