starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #384] [MERGED] feat(acls): add some logs and skip error #1419

New Issue
Closed
opened 2025-12-29 02:30:00 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/384
Author: @restanrm
Created: 3/2/2022
Status: ✅ Merged
Merged: 3/3/2022
Merged by: @kradalby

Base: main ← Head: fix-issue-with-empty-namespace-and-acl-evaluation

📝 Commits (1)

  • 4a49528 feat(acls): add some logs and skip error

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 acls.go (+7 -1)

📄 Description

logs looks like the following

2022-03-02T20:43:08Z DBG Expanding alias=app-test
2022-03-02T20:43:08Z DBG Expanding alias=kube-test
2022-03-02T20:43:08Z DBG Expanding alias=test
2022-03-02T20:43:08Z WRN No IPs found with the alias test
2022-03-02T20:43:08Z DBG Expanding alias=prod
2022-03-02T20:43:08Z WRN No IPs found with the alias prod
2022-03-02T20:43:08Z DBG Expanding alias=prod
2022-03-02T20:43:08Z WRN No IPs found with the alias prod
  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • [] added unit tests
  • [] added integration tests
  • [] updated documentation if needed
  • [] updated CHANGELOG.md

fixes #383
maybe related to issue reported on discord on ACLs that weren't parsed properly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/384 **Author:** [@restanrm](https://github.com/restanrm) **Created:** 3/2/2022 **Status:** ✅ Merged **Merged:** 3/3/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix-issue-with-empty-namespace-and-acl-evaluation` --- ### 📝 Commits (1) - [`4a49528`](https://github.com/juanfont/headscale/commit/4a4952899bdb5021d0d2d920b18bb38ea3ac92a2) feat(acls): add some logs and skip error ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `acls.go` (+7 -1) </details> ### 📄 Description logs looks like the following ``` 2022-03-02T20:43:08Z DBG Expanding alias=app-test 2022-03-02T20:43:08Z DBG Expanding alias=kube-test 2022-03-02T20:43:08Z DBG Expanding alias=test 2022-03-02T20:43:08Z WRN No IPs found with the alias test 2022-03-02T20:43:08Z DBG Expanding alias=prod 2022-03-02T20:43:08Z WRN No IPs found with the alias prod 2022-03-02T20:43:08Z DBG Expanding alias=prod 2022-03-02T20:43:08Z WRN No IPs found with the alias prod ``` <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [] added unit tests - [] added integration tests - [] updated documentation if needed - [] updated CHANGELOG.md fixes #383 maybe related to issue reported on discord on ACLs that weren't parsed properly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:00 +01:00
adam closed this issue 2025-12-29 02:30:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1419
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?