[PR #349] [MERGED] Remove dependency on CGO #1399

Closed
opened 2025-12-29 02:29:56 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/349
Author: @kradalby
Created: 2/22/2022
Status: Merged
Merged: 2/24/2022
Merged by: @kradalby

Base: mainHead: remove-cgo


📝 Commits (5)

  • bfbcea3 Remove dependency on CGO
  • 67f5c32 Only allow one connection to sqlite
  • f0a7363 Merge branch 'main' into remove-cgo
  • 686e45c Set all anti-cgo options and add comment
  • ed21757 Merge branch 'remove-cgo' of github.com:kradalby/headscale into remove-cgo

📊 Changes

9 files changed (+211 additions, -302 deletions)

View changed files

📝 .goreleaser.yml (+9 -18)
📝 CHANGELOG.md (+4 -0)
📝 Dockerfile (+1 -1)
📝 Dockerfile.alpine (+1 -1)
📝 Dockerfile.debug (+1 -1)
📝 Makefile (+1 -1)
📝 db.go (+20 -5)
📝 go.mod (+14 -7)
📝 go.sum (+160 -268)

📄 Description

This commit changes the SQLite dependency to one that does not depend on
CGO. It uses a C-to-Go translated sqlite library that is Pure go.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/349 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/22/2022 **Status:** ✅ Merged **Merged:** 2/24/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `remove-cgo` --- ### 📝 Commits (5) - [`bfbcea3`](https://github.com/juanfont/headscale/commit/bfbcea35a03fc7cd80a46a8b5a0c9b1fee5a1e24) Remove dependency on CGO - [`67f5c32`](https://github.com/juanfont/headscale/commit/67f5c32b49c68a873d095760315dd1e5ac9a8544) Only allow one connection to sqlite - [`f0a7363`](https://github.com/juanfont/headscale/commit/f0a73632e07b483db8bf63452328bb86f07a5560) Merge branch 'main' into remove-cgo - [`686e45c`](https://github.com/juanfont/headscale/commit/686e45cf27b9d509530f590fefffb90941cbdcbc) Set all anti-cgo options and add comment - [`ed21757`](https://github.com/juanfont/headscale/commit/ed2175706c724b3d4eeb63012a2289deedd04f43) Merge branch 'remove-cgo' of github.com:kradalby/headscale into remove-cgo ### 📊 Changes **9 files changed** (+211 additions, -302 deletions) <details> <summary>View changed files</summary> 📝 `.goreleaser.yml` (+9 -18) 📝 `CHANGELOG.md` (+4 -0) 📝 `Dockerfile` (+1 -1) 📝 `Dockerfile.alpine` (+1 -1) 📝 `Dockerfile.debug` (+1 -1) 📝 `Makefile` (+1 -1) 📝 `db.go` (+20 -5) 📝 `go.mod` (+14 -7) 📝 `go.sum` (+160 -268) </details> ### 📄 Description This commit changes the SQLite dependency to one that does not depend on CGO. It uses a C-to-Go translated sqlite library that is Pure go. <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [x] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:56 +01:00
adam closed this issue 2025-12-29 02:29:56 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1399