starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #347] [MERGED] Remove the concept of "shared nodes" #1395

New Issue
Closed
opened 2025-12-29 02:29:55 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/347
Author: @kradalby
Created: 2/22/2022
Status: ✅ Merged
Merged: 2/25/2022
Merged by: @kradalby

Base: main ← Head: remove-shared

📝 Commits (10+)

  • 9ceac5c Remove CLI and tests for Shared node
  • 6da2a19 Remove grpc share/unshare functions
  • 9d1752a Remove protobuf share/unshare
  • 9399754 Remove protobuf share/unshare generated go
  • 1e8f4db Drop shared node table
  • 9411ec4 Remove sharing class and tests
  • 24a8e19 Remove sharing references across the code
  • 4ca8181 Remove sharing from integration tests
  • f4c302f Uncomment tests that will failed in transition period
  • ec58979 Merge branch 'main' into remove-shared

📊 Changes

23 files changed (+284 additions, -1974 deletions)

View changed files

📝 cmd/headscale/cli/nodes.go (+0 -157)
📝 db.go (+1 -4)
📝 dns_test.go (+14 -20)
📝 gen/go/headscale/v1/apikey.pb.go (+2 -3)
📝 gen/go/headscale/v1/device.pb.go (+2 -3)
📝 gen/go/headscale/v1/headscale.pb.go (+96 -123)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+0 -238)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+4 -73)
📝 gen/go/headscale/v1/machine.pb.go (+53 -332)
📝 gen/go/headscale/v1/namespace.pb.go (+2 -3)
📝 gen/go/headscale/v1/preauthkey.pb.go (+2 -3)
📝 gen/go/headscale/v1/routes.pb.go (+2 -3)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+22 -88)
📝 grpcv1.go (+0 -53)
📝 integration_cli_test.go (+46 -149)
📝 integration_test.go (+4 -108)
📝 machine.go (+3 -104)
📝 namespaces.go (+0 -25)
📝 namespaces_test.go (+31 -33)
📝 proto/headscale/v1/headscale.proto (+0 -12)

...and 3 more files

📄 Description

This PR resolves #328, as it is no longer necessary in the new setup were all namespaces can talk to each other.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/347 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/22/2022 **Status:** ✅ Merged **Merged:** 2/25/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `remove-shared` --- ### 📝 Commits (10+) - [`9ceac5c`](https://github.com/juanfont/headscale/commit/9ceac5c0fc017e15670f4590aa6a8d1d5b281f77) Remove CLI and tests for Shared node - [`6da2a19`](https://github.com/juanfont/headscale/commit/6da2a19d1020cdc26fe57e9e80ba6778a235aa97) Remove grpc share/unshare functions - [`9d1752a`](https://github.com/juanfont/headscale/commit/9d1752acbc7a7b66c84f26e87317da77239038a2) Remove protobuf share/unshare - [`9399754`](https://github.com/juanfont/headscale/commit/93997544897778672c54552644d6e972623f2345) Remove protobuf share/unshare generated go - [`1e8f4db`](https://github.com/juanfont/headscale/commit/1e8f4dbdff593efa6c8f6003d8c7ad30ef8cb469) Drop shared node table - [`9411ec4`](https://github.com/juanfont/headscale/commit/9411ec47c303ebab227d575bc8af662a82d7fd6f) Remove sharing class and tests - [`24a8e19`](https://github.com/juanfont/headscale/commit/24a8e198a1280596345dd412a0b249a16f86bbd4) Remove sharing references across the code - [`4ca8181`](https://github.com/juanfont/headscale/commit/4ca8181dcbefdc89263d00d3de8ee86e2aab551b) Remove sharing from integration tests - [`f4c302f`](https://github.com/juanfont/headscale/commit/f4c302f1fb4daff1c1435881695af10872ffb03e) Uncomment tests that will failed in transition period - [`ec58979`](https://github.com/juanfont/headscale/commit/ec58979ce0e7843b8d56af75392a5bbb9ea84a82) Merge branch 'main' into remove-shared ### 📊 Changes **23 files changed** (+284 additions, -1974 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/nodes.go` (+0 -157) 📝 `db.go` (+1 -4) 📝 `dns_test.go` (+14 -20) 📝 `gen/go/headscale/v1/apikey.pb.go` (+2 -3) 📝 `gen/go/headscale/v1/device.pb.go` (+2 -3) 📝 `gen/go/headscale/v1/headscale.pb.go` (+96 -123) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+0 -238) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+4 -73) 📝 `gen/go/headscale/v1/machine.pb.go` (+53 -332) 📝 `gen/go/headscale/v1/namespace.pb.go` (+2 -3) 📝 `gen/go/headscale/v1/preauthkey.pb.go` (+2 -3) 📝 `gen/go/headscale/v1/routes.pb.go` (+2 -3) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+22 -88) 📝 `grpcv1.go` (+0 -53) 📝 `integration_cli_test.go` (+46 -149) 📝 `integration_test.go` (+4 -108) 📝 `machine.go` (+3 -104) 📝 `namespaces.go` (+0 -25) 📝 `namespaces_test.go` (+31 -33) 📝 `proto/headscale/v1/headscale.proto` (+0 -12) _...and 3 more files_ </details> ### 📄 Description This PR resolves #328, as it is no longer necessary in the new setup were all namespaces can talk to each other. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:55 +01:00
adam closed this issue 2025-12-29 02:29:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?