starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #344] [MERGED] Make /metrics listen on a different address #1394

New Issue
Closed
opened 2025-12-29 02:29:55 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/344
Author: @reynico
Created: 2/21/2022
Status: ✅ Merged
Merged: 3/2/2022
Merged by: @kradalby

Base: main ← Head: metrics-listen

📝 Commits (10+)

  • d5fd7a5 metrics: add a new router and listener for Prometheus' metrics endpoint
  • 45d5ab3 metrics/cfg: add a new entry for the Prometheus listen address
  • fbc1843 metrics/tests: update tests
  • 14e4988 metrics/kustomize: update Kustomize examples
  • e3bcc88 Linter: make linter happy
  • d27f2bc Merge branch 'main' into metrics-listen
  • d55c79e Merge branch 'main' into metrics-listen
  • a9122c3 prometheus: replace default port by a port between the recommended prometheus range
  • 06e6c29 metrics: make metrics endpoint toggleable
  • 6126d6d Merge branch 'main' into metrics-listen

📊 Changes

9 files changed (+55 additions, -3 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 app.go (+31 -3)
📝 cmd/headscale/cli/utils.go (+1 -0)
📝 cmd/headscale/headscale_test.go (+1 -0)
📝 config-example.yaml (+6 -0)
📝 docs/examples/kustomize/base/configmap.yaml (+1 -0)
📝 docs/examples/kustomize/postgres/deployment.yaml (+5 -0)
📝 docs/examples/kustomize/sqlite/statefulset.yaml (+5 -0)
📝 integration_test/etc/config.yaml (+1 -0)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Addresses #343

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/344 **Author:** [@reynico](https://github.com/reynico) **Created:** 2/21/2022 **Status:** ✅ Merged **Merged:** 3/2/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `metrics-listen` --- ### 📝 Commits (10+) - [`d5fd7a5`](https://github.com/juanfont/headscale/commit/d5fd7a5c001111a99e496018ceb1c509f7806189) metrics: add a new router and listener for Prometheus' metrics endpoint - [`45d5ab3`](https://github.com/juanfont/headscale/commit/45d5ab30ffa7cd3fc0e675312c8844e60d03e7db) metrics/cfg: add a new entry for the Prometheus listen address - [`fbc1843`](https://github.com/juanfont/headscale/commit/fbc1843889619a44488ff69e2e7c9dc191f876b2) metrics/tests: update tests - [`14e4988`](https://github.com/juanfont/headscale/commit/14e49885fbab368dfe1b782a45dd0fac9408f468) metrics/kustomize: update Kustomize examples - [`e3bcc88`](https://github.com/juanfont/headscale/commit/e3bcc88880eb2704dbcdb1eac79b79cfa48fe403) Linter: make linter happy - [`d27f2bc`](https://github.com/juanfont/headscale/commit/d27f2bc538e7d13e8f66b2312343140c18a32b02) Merge branch 'main' into metrics-listen - [`d55c79e`](https://github.com/juanfont/headscale/commit/d55c79e75b674995ac37c316a5121a03a9755e9b) Merge branch 'main' into metrics-listen - [`a9122c3`](https://github.com/juanfont/headscale/commit/a9122c3de37e91effc8951b117e87021ed282b4e) prometheus: replace default port by a port between the recommended prometheus range - [`06e6c29`](https://github.com/juanfont/headscale/commit/06e6c29a5b168731044ab40ca7dd19eb3417e263) metrics: make metrics endpoint toggleable - [`6126d6d`](https://github.com/juanfont/headscale/commit/6126d6d9b58718a629bac82dbffac4c92277ef04) Merge branch 'main' into metrics-listen ### 📊 Changes **9 files changed** (+55 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `app.go` (+31 -3) 📝 `cmd/headscale/cli/utils.go` (+1 -0) 📝 `cmd/headscale/headscale_test.go` (+1 -0) 📝 `config-example.yaml` (+6 -0) 📝 `docs/examples/kustomize/base/configmap.yaml` (+1 -0) 📝 `docs/examples/kustomize/postgres/deployment.yaml` (+5 -0) 📝 `docs/examples/kustomize/sqlite/statefulset.yaml` (+5 -0) 📝 `integration_test/etc/config.yaml` (+1 -0) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [x] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md Addresses #343 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:55 +01:00
adam closed this issue 2025-12-29 02:29:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1394
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?