starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #316] [MERGED] Remove kv-namespace-worker #1378

New Issue
Closed
opened 2025-12-29 02:29:52 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/316
Author: @kradalby
Created: 2/12/2022
Status: ✅ Merged
Merged: 2/14/2022
Merged by: @kradalby

Base: main ← Head: kv-worker-cleanup

📝 Commits (5)

  • 2bc8051 Remove kv-namespace-worker
  • 6fa0903 Update changelog
  • bb80b67 Remove RequestMapUpdates function
  • 546b1e8 Merge branch 'main' into kv-worker-cleanup
  • 57f1da6 Merge branch 'main' into kv-worker-cleanup

📊 Changes

7 files changed (+6 additions, -142 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 app.go (+0 -16)
📝 machine.go (+5 -10)
📝 machine_test.go (+0 -13)
📝 namespaces.go (+0 -93)
📝 routes.go (+0 -5)
📝 sharing.go (+0 -5)

📄 Description

This commit removes the namespace kv worker and related code, now that
we talk over gRPC to the server, and not directly to the DB, we should
not need this anymore.

Basically, I think this should be safe now, but not sure, let's see what the tests say. What do you think @juanfont

  • read the CONTRIBUTING guidelines
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/316 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/12/2022 **Status:** ✅ Merged **Merged:** 2/14/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kv-worker-cleanup` --- ### 📝 Commits (5) - [`2bc8051`](https://github.com/juanfont/headscale/commit/2bc8051ae52f7c48bfcf35d893a2b5563e7ffb2c) Remove kv-namespace-worker - [`6fa0903`](https://github.com/juanfont/headscale/commit/6fa0903a8e05a0d8d98068c4ca281fe5c4495c98) Update changelog - [`bb80b67`](https://github.com/juanfont/headscale/commit/bb80b679bc561681ed68880d383c5660752deb6f) Remove RequestMapUpdates function - [`546b1e8`](https://github.com/juanfont/headscale/commit/546b1e8a058c0dbbb78ef39718a56dda0e6f7478) Merge branch 'main' into kv-worker-cleanup - [`57f1da6`](https://github.com/juanfont/headscale/commit/57f1da6dca65aa616959d238624b4898cb279744) Merge branch 'main' into kv-worker-cleanup ### 📊 Changes **7 files changed** (+6 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `app.go` (+0 -16) 📝 `machine.go` (+5 -10) 📝 `machine_test.go` (+0 -13) 📝 `namespaces.go` (+0 -93) 📝 `routes.go` (+0 -5) 📝 `sharing.go` (+0 -5) </details> ### 📄 Description This commit removes the namespace kv worker and related code, now that we talk over gRPC to the server, and not directly to the DB, we should not need this anymore. Basically, I think this should be safe now, but not sure, let's see what the tests say. What do you think @juanfont <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] added unit tests - [x] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:52 +01:00
adam closed this issue 2025-12-29 02:29:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1378
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?