starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #289] [MERGED] Trim whitespace from privateKey before parsing #1360

New Issue
Closed
opened 2025-12-29 02:29:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/289
Author: @kradalby
Created: 1/28/2022
Status: ✅ Merged
Merged: 1/29/2022
Merged by: @kradalby

Base: main ← Head: whitespace

📝 Commits (2)

  • f59071f Trim whitespace from privateKey before parsing
  • ab45cd3 Only golint new problems

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 .github/workflows/lint.yml (+6 -0)
📝 app.go (+2 -1)

📄 Description

This PR removes potential whitespace from the private key before we try to unmarshal it. It helps us deal with issues were e.g. secrets management systems add a new line.

Fixes #287

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/289 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 1/28/2022 **Status:** ✅ Merged **Merged:** 1/29/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `whitespace` --- ### 📝 Commits (2) - [`f59071f`](https://github.com/juanfont/headscale/commit/f59071ff1c2da7f03cd58b626f2267ab14905352) Trim whitespace from privateKey before parsing - [`ab45cd3`](https://github.com/juanfont/headscale/commit/ab45cd37f8cf9203fcc6c14865d0e33271036ac9) Only golint new problems ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/lint.yml` (+6 -0) 📝 `app.go` (+2 -1) </details> ### 📄 Description This PR removes potential whitespace from the private key before we try to unmarshal it. It helps us deal with issues were e.g. secrets management systems add a new line. Fixes #287 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:49 +01:00
adam closed this issue 2025-12-29 02:29:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1360
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?