starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #278] [MERGED] PollNetMapStream: do not create any rows during long-poll operation #1359

New Issue
Closed
opened 2025-12-29 02:29:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/278
Author: @enoperm
Created: 1/16/2022
Status: ✅ Merged
Merged: 1/29/2022
Merged by: @kradalby

Base: main ← Head: pollnetmap-update-only

📝 Commits (5)

  • 25ccf5e PollNetMapStream: do not create any rows during long-poll operation
  • 761147e update CHANGELOG
  • fbe5054 fixup! update CHANGELOG
  • 17411b6 fixup! fixup! update CHANGELOG
  • 6f9ed95 Merge branch 'main' into pollnetmap-update-only

📊 Changes

3 files changed (+78 additions, -17 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 machine.go (+8 -0)
📝 poll.go (+67 -17)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand - found existing issues.
  • added unit tests - testing requires a client, currently only available in integration tests.
  • ] added integration tests
  • updated documentation if needed - PR contains changes without changes to expected behaviour towards clients or users.
  • updated CHANGELOG.md

Fixes #232 (manually tested in the no-preauthkeys case)
Related to #93

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/278 **Author:** [@enoperm](https://github.com/enoperm) **Created:** 1/16/2022 **Status:** ✅ Merged **Merged:** 1/29/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `pollnetmap-update-only` --- ### 📝 Commits (5) - [`25ccf5e`](https://github.com/juanfont/headscale/commit/25ccf5ef1808375a17337e9f1a2562858c5edb7e) PollNetMapStream: do not create any rows during long-poll operation - [`761147e`](https://github.com/juanfont/headscale/commit/761147ea3be88ea0531f688ed2e89840f124d92d) update CHANGELOG - [`fbe5054`](https://github.com/juanfont/headscale/commit/fbe5054a6707ce8a4020fd773061e2284a6ef6d7) fixup! update CHANGELOG - [`17411b6`](https://github.com/juanfont/headscale/commit/17411b65f34334c18b446126a8f0d01e488026a0) fixup! fixup! update CHANGELOG - [`6f9ed95`](https://github.com/juanfont/headscale/commit/6f9ed958ca0fdcc90847a95f83d8b360cecab286) Merge branch 'main' into pollnetmap-update-only ### 📊 Changes **3 files changed** (+78 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `machine.go` (+8 -0) 📝 `poll.go` (+67 -17) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - ~~raised a GitHub issue or discussed it on the projects chat beforehand~~ - found existing issues. - ~~added unit tests~~ - testing requires a client, currently only available in integration tests. - ~~] added integration tests~~ - updated documentation if ~~needed~~ - PR contains changes without changes to expected behaviour towards clients or users. - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> Fixes #232 (manually tested in the no-preauthkeys case) Related to #93 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:49 +01:00
adam closed this issue 2025-12-29 02:29:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?