starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 12:20:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #274] [MERGED] Strip binary, update to go-1.17.6 #1356

New Issue
Closed
opened 2025-12-29 02:29:48 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/274
Author: @majst01
Created: 1/14/2022
Status: ✅ Merged
Merged: 1/20/2022
Merged by: @juanfont

Base: main ← Head: reduce-binary-size

📝 Commits (3)

  • 1d68509 Strip binary, update to go-1.17.6
  • febbb60 use most recent go 1.17 for tests
  • 3837f17 Merge branch 'main' into reduce-binary-size

📊 Changes

5 files changed (+7 additions, -5 deletions)

View changed files

📝 .github/workflows/build.yml (+1 -1)
📝 .github/workflows/test-integration.yml (+1 -1)
📝 .github/workflows/test.yml (+1 -1)
📝 Dockerfile (+2 -1)
📝 Dockerfile.alpine (+2 -1)

📄 Description

With this PR the binary is compiled with go 1.17.6 to close some of the open CVE´s in go 1.17.1.
Furthermore the resulting binary is stripped which reduces the size of the binary by ~10MB.

before:
-rwxr-xr-x    1 root     root      32766008 Jan 13 16:07 /bin/headscale

after:
-rwxr-xr-x    1 root     root      22325232 Jan 14 08:14 /bin/headscale
  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/274 **Author:** [@majst01](https://github.com/majst01) **Created:** 1/14/2022 **Status:** ✅ Merged **Merged:** 1/20/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `reduce-binary-size` --- ### 📝 Commits (3) - [`1d68509`](https://github.com/juanfont/headscale/commit/1d68509463124138f04ea736dd3aa75c1e47f574) Strip binary, update to go-1.17.6 - [`febbb60`](https://github.com/juanfont/headscale/commit/febbb6006f040b26bfe30db31ed4dee7ea362540) use most recent go 1.17 for tests - [`3837f17`](https://github.com/juanfont/headscale/commit/3837f1714a7111ce1f0132dfef1190ca033e9b20) Merge branch 'main' into reduce-binary-size ### 📊 Changes **5 files changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+1 -1) 📝 `.github/workflows/test-integration.yml` (+1 -1) 📝 `.github/workflows/test.yml` (+1 -1) 📝 `Dockerfile` (+2 -1) 📝 `Dockerfile.alpine` (+2 -1) </details> ### 📄 Description With this PR the binary is compiled with go 1.17.6 to close some of the open CVE´s in go 1.17.1. Furthermore the resulting binary is stripped which reduces the size of the binary by ~10MB. ``` before: -rwxr-xr-x 1 root root 32766008 Jan 13 16:07 /bin/headscale after: -rwxr-xr-x 1 root root 22325232 Jan 14 08:14 /bin/headscale ``` - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:48 +01:00
adam closed this issue 2025-12-29 02:29:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1356
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?