starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #229] [MERGED] Upgrade Tailscale version to 1.18.x #1330

New Issue
Closed
opened 2025-12-29 02:29:43 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/229
Author: @kradalby
Created: 11/19/2021
Status: ✅ Merged
Merged: 11/28/2021
Merged by: @kradalby

Base: main ← Head: kradalby-patch-2

📝 Commits (10+)

  • 5a2cae5 Add new Tailscale version to integration tests
  • 3492648 Use .1
  • aab4a60 Merge branch 'main' into kradalby-patch-2
  • 50b47ad Upgrade tailscale to 1.18
  • c63c259 Switch wgkey for types/key
  • 0741814 Remove config loading of private key path
  • cfd53bc Factor wgkey to types/key
  • 0012c76 Make it easier to run cli integration tests
  • c38f00f Unmarshal keys in the non-deprecated way
  • 59aeaa8 Ensure we always have the key prefix when needed

📊 Changes

23 files changed (+476 additions, -281 deletions)

View changed files

📝 .github/workflows/test-integration.yml (+1 -1)
📝 .github/workflows/test.yml (+1 -1)
📝 Makefile (+3 -0)
📝 api.go (+47 -46)
📝 app.go (+54 -18)
📝 cmd/headscale/cli/nodes.go (+5 -4)
📝 cmd/headscale/cli/utils.go (+1 -1)
📝 config-example.yaml (+0 -3)
📝 docs/Configuration.md (+0 -6)
📝 docs/DNS.md (+0 -1)
📝 docs/Running.md (+1 -3)
📝 go.mod (+97 -25)
📝 go.sum (+59 -26)
📝 integration_cli_test.go (+1 -1)
📝 integration_test.go (+45 -41)
➖ integration_test/etc/private.key (+0 -1)
📝 k8s/postgres/deployment.yaml (+0 -2)
📝 k8s/sqlite/statefulset.yaml (+0 -2)
📝 machine.go (+43 -27)
📝 oidc.go (+14 -2)

...and 3 more files

📄 Description

See individual commits.

There is a new key library, and it forces some refactoring, I might have missed something, but this should have integration tests passing for the new and the previous version when its done.

This PR contains a breaking change.

The old private key format is no longer supported, and users will have to delete their private key. Headscale will now automatically generate it on startup if it does not exist.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/229 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/19/2021 **Status:** ✅ Merged **Merged:** 11/28/2021 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby-patch-2` --- ### 📝 Commits (10+) - [`5a2cae5`](https://github.com/juanfont/headscale/commit/5a2cae508160b482510ba8999d6354a001b85fce) Add new Tailscale version to integration tests - [`3492648`](https://github.com/juanfont/headscale/commit/349264830b6689edd7d2f008cdc03c32ed4a55e0) Use .1 - [`aab4a60`](https://github.com/juanfont/headscale/commit/aab4a6043a777520e7c5aa783b9d89c274a37bef) Merge branch 'main' into kradalby-patch-2 - [`50b47ad`](https://github.com/juanfont/headscale/commit/50b47adaa3fa0db6878be66154dd82fa1aee6c9d) Upgrade tailscale to 1.18 - [`c63c259`](https://github.com/juanfont/headscale/commit/c63c259d319fe3b03535cf4989e9c9039ec87134) Switch wgkey for types/key - [`0741814`](https://github.com/juanfont/headscale/commit/07418140a2b5bebafc20a87f5a87c9f2b619b427) Remove config loading of private key path - [`cfd53bc`](https://github.com/juanfont/headscale/commit/cfd53bc4aafaeed912330db7c2698ada135afa4e) Factor wgkey to types/key - [`0012c76`](https://github.com/juanfont/headscale/commit/0012c7617067e6b02b6d55ad9a264f7c786f7c69) Make it easier to run cli integration tests - [`c38f00f`](https://github.com/juanfont/headscale/commit/c38f00fab85d3e77d99f3796683d4c5913ef2931) Unmarshal keys in the non-deprecated way - [`59aeaa8`](https://github.com/juanfont/headscale/commit/59aeaa8476aa6043f830dc2e2bd8bbff3693a799) Ensure we always have the key prefix when needed ### 📊 Changes **23 files changed** (+476 additions, -281 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yml` (+1 -1) 📝 `.github/workflows/test.yml` (+1 -1) 📝 `Makefile` (+3 -0) 📝 `api.go` (+47 -46) 📝 `app.go` (+54 -18) 📝 `cmd/headscale/cli/nodes.go` (+5 -4) 📝 `cmd/headscale/cli/utils.go` (+1 -1) 📝 `config-example.yaml` (+0 -3) 📝 `docs/Configuration.md` (+0 -6) 📝 `docs/DNS.md` (+0 -1) 📝 `docs/Running.md` (+1 -3) 📝 `go.mod` (+97 -25) 📝 `go.sum` (+59 -26) 📝 `integration_cli_test.go` (+1 -1) 📝 `integration_test.go` (+45 -41) ➖ `integration_test/etc/private.key` (+0 -1) 📝 `k8s/postgres/deployment.yaml` (+0 -2) 📝 `k8s/sqlite/statefulset.yaml` (+0 -2) 📝 `machine.go` (+43 -27) 📝 `oidc.go` (+14 -2) _...and 3 more files_ </details> ### 📄 Description See individual commits. There is a new key library, and it forces some refactoring, I might have missed something, but this should have integration tests passing for the new and the previous version when its done. This PR contains a **breaking change**. The old private key format is no longer supported, and users will have to delete their private key. Headscale will now automatically generate it on startup if it does not exist. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:43 +01:00
adam closed this issue 2025-12-29 02:29:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1330
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?