starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #224] [MERGED] Improvements for namespace deletion #1328

New Issue
Closed
opened 2025-12-29 02:29:43 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/224
Author: @cure
Created: 11/13/2021
Status: ✅ Merged
Merged: 11/14/2021
Merged by: @kradalby

Base: main ← Head: namespace-deletion-fixes

📝 Commits (2)

  • acf7e46 Improvements for namespace deletion: add a confirmation prompt, and make
  • 34dba0a Fix missing error check.

📊 Changes

4 files changed (+71 additions, -10 deletions)

View changed files

📝 cmd/headscale/cli/namespaces.go (+31 -5)
📝 namespaces.go (+15 -4)
📝 namespaces_test.go (+15 -1)
📝 preauth_keys.go (+10 -0)

📄 Description

Add a confirmation prompt and make sure to also delete any associated preauthkeys. This fixes issue #217.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/224 **Author:** [@cure](https://github.com/cure) **Created:** 11/13/2021 **Status:** ✅ Merged **Merged:** 11/14/2021 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `namespace-deletion-fixes` --- ### 📝 Commits (2) - [`acf7e46`](https://github.com/juanfont/headscale/commit/acf7e462adaea2c7e2c9ab1e0a0b5c3554a4dab6) Improvements for namespace deletion: add a confirmation prompt, and make - [`34dba0a`](https://github.com/juanfont/headscale/commit/34dba0ade864ee4bceb8cf7264c84c865ca828de) Fix missing error check. ### 📊 Changes **4 files changed** (+71 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/namespaces.go` (+31 -5) 📝 `namespaces.go` (+15 -4) 📝 `namespaces_test.go` (+15 -1) 📝 `preauth_keys.go` (+10 -0) </details> ### 📄 Description Add a confirmation prompt and make sure to also delete any associated preauthkeys. This fixes issue #217. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:43 +01:00
adam closed this issue 2025-12-29 02:29:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1328
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?