[PR #185] [CLOSED] fix apple configuration profile links #1305

Closed
opened 2025-12-29 02:29:38 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/185
Author: @derelm
Created: 10/20/2021
Status: Closed

Base: mainHead: patch-1


📝 Commits (6)

  • 2a17310 fix apple configuration profile links
  • 6f8fb26 Merge branch 'main' into patch-1
  • 3e10bbd Merge branch 'main' into patch-1
  • 1cac688 Merge branch 'main' into patch-1
  • df10dd9 Merge branch 'main' into patch-1
  • 10af4ab Merge branch 'main' into patch-1

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 apple_mobileconfig.go (+2 -2)

📄 Description

when headscale is mounted in a subpath of a domain these links pointed to potentially invalid urls.
another potential fix would be to use relative links (dropping {{.Url}}/ in all urls).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/185 **Author:** [@derelm](https://github.com/derelm) **Created:** 10/20/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (6) - [`2a17310`](https://github.com/juanfont/headscale/commit/2a173107c10d67c90d4ee5f5dd6d6288d829d94d) fix apple configuration profile links - [`6f8fb26`](https://github.com/juanfont/headscale/commit/6f8fb261d138f0d72452c4482f60c92580f73a43) Merge branch 'main' into patch-1 - [`3e10bbd`](https://github.com/juanfont/headscale/commit/3e10bbd1ad53fa6b5d8a51e6ddbf3de82eb16f0c) Merge branch 'main' into patch-1 - [`1cac688`](https://github.com/juanfont/headscale/commit/1cac688b3abc1a7d9916ce28496cd6af5fd7b551) Merge branch 'main' into patch-1 - [`df10dd9`](https://github.com/juanfont/headscale/commit/df10dd9c21bd5fe5fc8be835c988c8acb42f6962) Merge branch 'main' into patch-1 - [`10af4ab`](https://github.com/juanfont/headscale/commit/10af4abed7d5c2cc9dd1b7e2b3b5f5aed974c335) Merge branch 'main' into patch-1 ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apple_mobileconfig.go` (+2 -2) </details> ### 📄 Description when headscale is mounted in a subpath of a domain these links pointed to potentially invalid urls. another potential fix would be to use relative links (dropping `{{.Url}}/` in all urls). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:38 +01:00
adam closed this issue 2025-12-29 02:29:38 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1305