starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Investigate not writing a machine to DB until registered #130

New Issue
Closed
opened 2025-12-29 01:23:39 +01:00 by adam · 3 comments
adam commented 2025-12-29 01:23:39 +01:00
Owner
Copy Link

Originally created by @kradalby on GitHub (Feb 20, 2022).

Currently a Machine object is created in the database immediately when the registration process starts, and not always clean up.

This seem to be to hold temporary data between requests during the registration process.

This often leads to half-finished machine objects being left around in the database, this specially happens when registering Windows clients for some reason.

This ticket is to track an effort to not save the machine object to the database until it is actually registered, as there is no real point to have it in there. Any in-flight registration should be able to live in memory until complete.

Originally created by @kradalby on GitHub (Feb 20, 2022). Currently a Machine object is created in the database immediately when the registration process starts, and not always clean up. This seem to be to hold temporary data between requests during the registration process. This often leads to half-finished machine objects being left around in the database, this specially happens when registering Windows clients for some reason. This ticket is to track an effort to not save the machine object to the database until it is actually registered, as there is no real point to have it in there. Any in-flight registration should be able to live in memory until complete.
adam added the enhancement label 2025-12-29 01:23:39 +01:00
adam closed this issue 2025-12-29 01:23:40 +01:00
adam commented 2025-12-29 01:23:40 +01:00
Author
Owner
Copy Link

@restanrm commented on GitHub (Feb 22, 2022):

Could it be instead put in special table with expiration date and cleanup job ?

I'm thinking that in case of distributed deployment, in memory state will not work.

@restanrm commented on GitHub (Feb 22, 2022): Could it be instead put in special table with expiration date and cleanup job ? I'm thinking that in case of distributed deployment, in memory state will not work.
adam commented 2025-12-29 01:23:40 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Feb 22, 2022):

That would be a possibility, I want it to have as little logic as possible, registration should not need to be inflight for long.

but I dont know what is a good approach, so needs some thought.

@kradalby commented on GitHub (Feb 22, 2022): That would be a possibility, I want it to have as little logic as possible, registration _should_ not need to be inflight for long. but I dont know what is a good approach, so needs some thought.
adam commented 2025-12-29 01:23:42 +01:00
Author
Owner
Copy Link

@restanrm commented on GitHub (Feb 22, 2022):

An in-memory solution seems quite good. It still should be implemented with interfaces in mind to be replacable by a small implementation of an external service like Redis in my opinion

@restanrm commented on GitHub (Feb 22, 2022): An in-memory solution seems quite good. It still should be implemented with interfaces in mind to be replacable by a small implementation of an external service like Redis in my opinion
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?