starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #167] [MERGED] Preload AuthKey Namespace on list nodes #1297

New Issue
Closed
opened 2025-12-29 02:29:36 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/167
Author: @juanfont
Created: 10/15/2021
Status: ✅ Merged
Merged: 10/16/2021
Merged by: @juanfont

Base: main ← Head: authkey-namespace-preload

📝 Commits (2)

  • 985c6e7 Preload AuthKey Namespace on list nodes (fixes #163)
  • 0b0f7db Merge branch 'main' into authkey-namespace-preload

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 namespaces.go (+1 -1)

📄 Description

The nested Namespace inside AuthKey was not being preloaded when using ListMachinesInNamespace, so it would appear empty when listing nodes with -o json.

This PR fixes #163.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/167 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 10/15/2021 **Status:** ✅ Merged **Merged:** 10/16/2021 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `authkey-namespace-preload` --- ### 📝 Commits (2) - [`985c6e7`](https://github.com/juanfont/headscale/commit/985c6e7cc90b8d896afac8e1a236756b8aa46011) Preload AuthKey Namespace on list nodes (fixes #163) - [`0b0f7db`](https://github.com/juanfont/headscale/commit/0b0f7db5349fe18bee2022cb9be25910d5a6678d) Merge branch 'main' into authkey-namespace-preload ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `namespaces.go` (+1 -1) </details> ### 📄 Description The nested `Namespace` inside `AuthKey` was not being preloaded when using `ListMachinesInNamespace`, so it would appear empty when listing nodes with `-o json`. This PR fixes #163. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:36 +01:00
adam closed this issue 2025-12-29 02:29:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1297
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?